Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When choosing between dependency versions, use SemVer #14

Open
dscho opened this issue May 22, 2014 · 3 comments
Open

When choosing between dependency versions, use SemVer #14

dscho opened this issue May 22, 2014 · 3 comments

Comments

@dscho
Copy link
Contributor

dscho commented May 22, 2014

MiniMaven can only handle one dependency version at a time. For example, if two pom-scijava versions are specified in the dependency tree, only one is used.

We should assume that SemVer is in effect, and use the newer of both dependency versions if the major version agrees.

When the major version disagrees, we should go with the newer one but complain really loudly.

@dscho dscho self-assigned this May 22, 2014
@ctrueden
Copy link
Member

Do you mean "two scijava-common versions"? Because as things stand, nothing would ever declare a dependency on pom-scijava. (We might some day use the <scope>import</scope> with it, but right now we are not doing that.)

@dscho
Copy link
Contributor Author

dscho commented May 22, 2014

I used the term "dependency" very sloppily. What I really meant was: when encountering different .pom versions of the same groupId/artifactId combination, MiniMaven retains only one version:

String key = dependency.getKey();

@ctrueden
Copy link
Member

Ah OK, understood then.

@dscho dscho removed their assignment Nov 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants