RFC Process for giving commit rights

[rth]

I think we should formalize a bit way commit rights are given for scikit-learn-extra.

Currently following groups can modify code in this repo,

• @scikit-learn-contrib/scikit-learn-extra team (currently containing @glemaitre and myself)¹
• owners of the scikit-learn-contrib org (28 people in total)

I think this is not very sustainable and we should give commit rights to scikit-learn-extra for contributors who have made significant contributions (in code or otherwise cf https://scikit-learn.org/stable/developers/contributing.html) and are interested/available in helping with the maintenance work.

(Also I guess the use of groups for managing permissions in this org could be improved in general).

[glemaitre]

I think this is not very sustainable and we should give commit rights to scikit-learn-extra for contributors who have made significant contributions (in code or otherwise cf https://scikit-learn.org/stable/developers/contributing.html) and are interested/available in helping with the maintenance work.

I am +1

[amueller]

yeah happy to expand the committer base if you have an idea who to add.

[rth]

I would like to give commit rights for this repo to @chkoar who helped with code review and is already co-maintaining imbalanced-learn.

[glemaitre]

+1

[GaelVaroquaux]

+1

[adrinjalali]

+1

[agramfort]

no objection

…

[rth]

It's done :)

[chkoar]

+1

[rth]

I would like to propose to add https://github.com/TimotheeMathieu to the scikit-learn-extra repo team, who has been doing useful contributions to this library for the last several months.

[GaelVaroquaux]

Fine for me! Thanks for suggesting

[rth]

It's done.