[WIP] Fix script fix_trk #984
Conversation
|
Hello @EmmaRenauld, Thank you for submitting the Pull Request !
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #984 +/- ##
==========================================
+ Coverage 68.00% 68.22% +0.21%
==========================================
Files 419 419
Lines 21569 21574 +5
Branches 3242 3244 +2
==========================================
+ Hits 14668 14718 +50
+ Misses 5609 5552 -57
- Partials 1292 1304 +12
|
|
|
||
| else: | ||
| sft.to_vox() | ||
| sft.streamlines._data -= get_axis_flip_vector(flip_axis) # --------------------_> HEin? |
There was a problem hiding this comment.
@frheault can you help with this one please ?
There was a problem hiding this comment.
I dont have data from StarTrack, but since there is a flip in X for everything we cannot use 'to_corner()' or 'to_center()' since it would shift it in the opposite direction. I believe this was the equivalent of centering the streamlines to the voxel before flipping.
DSI is flip in X/Y (LPS instead of RAS), so the shift is made to center streamlines to the voxel before the flip.
There was a problem hiding this comment.
When we talked about it a few months ago, I think we decided there are an error in the script. Arnaud, you said you would make some tests.
[WIP]
Todo. @arnaudbore , you told me you were managing this. Adding my attempt at changes here so that they are not lost. See my comment "hein???" in the main.