From 8a44c24b31c7914db7c81f8e49182e057a0188e7 Mon Sep 17 00:00:00 2001 From: Sebastien Date: Wed, 24 Apr 2024 16:11:03 +0200 Subject: [PATCH] build: execute perf test when updating release (#848) --- .github/workflows/on-main-push.yml | 5 +++-- .github/workflows/on-merged-pull-request.yml | 6 +++--- .github/workflows/on-pull-request.yml | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/on-main-push.yml b/.github/workflows/on-main-push.yml index 527feea6..48b1ad9d 100644 --- a/.github/workflows/on-main-push.yml +++ b/.github/workflows/on-main-push.yml @@ -19,6 +19,7 @@ jobs: runs-on: ubuntu-latest outputs: release_created: ${{ steps.release.outputs.release_created }} + prs_created: ${{ steps.release.outputs.prs_created }} version: ${{ steps.release.outputs.version }} steps: - uses: google-github-actions/release-please-action@v4 @@ -30,7 +31,7 @@ jobs: release: needs: [prepare-release] runs-on: ubuntu-latest - if: needs.prepare-release.outputs.release_created == 'true' + if: ${{ needs.prepare-release.outputs.release_created == 'true' }} steps: - name: Checkout sources uses: actions/checkout@v4 @@ -59,7 +60,7 @@ jobs: perf: needs: [prepare-release] runs-on: ubuntu-latest - if: needs.prepare-release.outputs.release_created != 'true' + if: ${{ needs.prepare-release.outputs.release_created != 'true' && needs.prepare-release.outputs.prs_created == 'true' }} steps: - name: Checkout sources uses: actions/checkout@v4 diff --git a/.github/workflows/on-merged-pull-request.yml b/.github/workflows/on-merged-pull-request.yml index 4d68f638..0f02bbf4 100644 --- a/.github/workflows/on-merged-pull-request.yml +++ b/.github/workflows/on-merged-pull-request.yml @@ -8,7 +8,7 @@ on: jobs: clean-npm-dev-version: - if: github.event.pull_request.merged == true + if: ${{ github.event.pull_request.merged == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout sources @@ -42,9 +42,9 @@ jobs: env: NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}} - - name: Delete package dev channel PR comment + - name: Delete package dev channel PR comment uses: thollander/actions-comment-pull-request@v2 with: - message: + message: "" comment_tag: dev-publish mode: delete diff --git a/.github/workflows/on-pull-request.yml b/.github/workflows/on-pull-request.yml index 271c5536..1457664c 100644 --- a/.github/workflows/on-pull-request.yml +++ b/.github/workflows/on-pull-request.yml @@ -103,7 +103,7 @@ jobs: publish-dev: needs: [build] runs-on: ubuntu-latest - if: github.event.pull_request.merged != 'true' && github.actor != 'dependabot[bot]' + if: ${{ github.event.pull_request.merged != 'true' && github.actor != 'dependabot[bot]' }} outputs: devChannel: ${{ steps.define_dev_channel.outputs.DEV_CHANNEL }} steps: