From 988b051d6fa8d6d197e7e012acc6fb1f862d28fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Colladon?= Date: Sun, 5 May 2024 19:13:50 +0200 Subject: [PATCH] refactor: simplify implementation --- src/service/inFileHandler.ts | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/service/inFileHandler.ts b/src/service/inFileHandler.ts index 70c90b69..e763989b 100644 --- a/src/service/inFileHandler.ts +++ b/src/service/inFileHandler.ts @@ -49,7 +49,7 @@ export default class InFileHandler extends StandardHandler { this._storeComparison(this.diffs.destructiveChanges, deleted) this._storeComparison(this.diffs.package, added) const { xmlContent, isEmpty } = this.metadataDiff.prune() - if (this._shouldTreatContainerType(added, isEmpty)) { + if (this._shouldTreatContainerType(isEmpty)) { // Call from super.handleAddition to add the Root Type // QUESTION: Why InFile element are not deployable when root component is not listed in package.xml ? await super.handleAddition() @@ -95,17 +95,7 @@ export default class InFileHandler extends StandardHandler { return this.metadataDef.pruneOnly } - protected _shouldTreatContainerType(added: Manifest, fileIsEmpty: boolean) { - if (!fileIsEmpty) { - return true - } - - for (const [type] of added) { - if (isPackable(type)) { - return true - } - } - - return false + protected _shouldTreatContainerType(fileIsEmpty: boolean) { + return !fileIsEmpty } }