any negative / unintended consequences of using a #!/bin/bash shebang or sourcing a file from /etc/default?

[iconoclasthero]

NB: I'm specifically not asking about style or personal preference here but rather if I'm introducing problems on a completion that is -x (or personal editor or path naming preferences).

A discussion on #bash intimated that I should refer specifically to the bash-completion package if I'm going to be putting these in /etc/bash_completion.d on a system with bash-completion Version: 1:2.16.0-7. Chapter 8 doesn't seem to say one way or other if either of these are a concern for bash itself.

• nano's not automatically doing context highlighting when I edit completion files so I added the shebang.
• rather than hardcoding variables for mpd or pulling them out of /etc/mpd.conf, I've a file that just lists them.

#!/bin/bash

. /etc/default/mpd-local.conf

_add_complete() {
    local cur="${COMP_WORDS[COMP_CWORD]}"  # Current word being typed

    [[ ! "$musicdir" ]] && local musicdir="/library/music"

    local results
    readarray -t COMPREPLY < <(
      while IFS= read -r f; do
        [[ -d "$f" ]] && f="$f/"
        f="${f#"$musicdir/"}"
        echo "$f"
      done < <(compgen -f -- "$musicdir/$cur")
    )
}

complete -o nospace -fd -F _add_complete add

Given the above: are there any unintended or negative consequences of including the shebang on a nonexecutable (-x) file sourcing a list of variables from /etc/default that is in /etc/bash_completion.d/?

[akinomyoga]

As far as bash-completion is concerned, there wouldn't be negative consequences of putting #!/bin/bash at the beginning of files in /etc/bash_completion.d.

However, I think you can simply use the filename extension .bash for the editor's language detection.

[iconoclasthero]

Thanks.

My habit has been to do this as I'm working to save versions.... ostensibly I can go back and clean that stuff up at some point (but nano doesn't care about that).

$ ll mpctitle*
.rwxrwxr-x 7.7k  7 Jan 09:14 mpctitle-0
lrwxrwxrwx    -  7 Jan 09:14 mpctitle -> mpctitle-3
.rwxrwxr-x 3.8k  7 Jan 09:14 mpctitle-2
.rwxrwxr-x 5.6k  7 Jan 09:14 mpctitle-1
.rw-rw-r--  760 29 Jan 11:52 mpctitle-completion.bash-0
lrwxrwxrwx    - 29 Jan 13:14 mpctitle-completion.bash -> mpctitle-completion.bash-1
.rw-rw-r-- 1.1k 29 Jan 14:00 mpctitle-completion.bash-1
.rwxrwxr-x  12k 29 Jan 14:10 mpctitle-3

[akinomyoga]

Obviously, you can put a number before the filename extension.

[iconoclasthero]

As far as bash-completion is concerned, there wouldn't be negative consequences of putting #!/bin/bash at the beginning of files in /etc/bash_completion.d.

However, I think you can simply use the filename extension .bash for the editor's language detection.

I guess the consequence of sourcing the file with the mpd variables in it means that they're going to be in the environment...so I'd be better off just grepping that out of the file instead.