Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create config for settings. #7

Open
dietergeerts opened this issue Jan 15, 2015 · 3 comments
Open

Create config for settings. #7

dietergeerts opened this issue Jan 15, 2015 · 3 comments

Comments

@dietergeerts
Copy link

Hi, Great directive! Simple and effective, better than other I could find, especially because the hash isn't shown in the location and you can use any css selector.

One 'problem' though. I would like to use some other default values, like for example the offset. Now I need to add this every time. So could you expose a config to configure these defaults?

@scottcorgan
Copy link
Owner

How would you like to see this config? During the config phase of Angular bootstrapping the app?

Let me know and I'll see what it will take to make that happen.

@dietergeerts
Copy link
Author

Hi, I forked the project and already added the config. I used another fork as it has some bug fixes and a controller call added I would like to use. I did a pull request there first, Maybe after that one all those changes can be merged with the Original? (https://github.com/mkirchstein/angular-scrollto/pull/1) And npm update so I can include it in my project?

@scottcorgan
Copy link
Owner

I'd like to see that merged into this repo as well, but I've got no pull request. @mkirchstein, want to submit a PR with your fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants