Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file/line references where appropriate #1

Open
scottmmjackson opened this issue May 30, 2023 · 0 comments
Open

Add file/line references where appropriate #1

scottmmjackson opened this issue May 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@scottmmjackson
Copy link
Owner

I've got to figure out a meaningful way to allow injection of file/line references. What makes this difficult is that it requires either two bulk calls (one to tasks and one to comments, which hold the inline info when present) or an individual comment API call per unresolved task.

I think, however, that bulk fetching comments is probably more likely to be faster and more API-economical in the general case. Obviously there's exceptions for PRs with 50 pages of comments but 2 open tasks; you're making 50 comment API hits per task sync versus 2.

Then there's the question of how to integrate it into existing behavior. I've got 2 watchers, and I'm at 0.0.4, so I don't feel terrible about drastically changing the ergonomics of the tool at this point. I'd considered allowing custom templates, but I'm thinking it might be smarter to make a handful of custom templates that handle most common cases. This way, I can use the template flag to carry the right context down and fetch only what the user wants to see.

@scottmmjackson scottmmjackson added the enhancement New feature or request label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant