You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've got to figure out a meaningful way to allow injection of file/line references. What makes this difficult is that it requires either two bulk calls (one to tasks and one to comments, which hold the inline info when present) or an individual comment API call per unresolved task.
I think, however, that bulk fetching comments is probably more likely to be faster and more API-economical in the general case. Obviously there's exceptions for PRs with 50 pages of comments but 2 open tasks; you're making 50 comment API hits per task sync versus 2.
Then there's the question of how to integrate it into existing behavior. I've got 2 watchers, and I'm at 0.0.4, so I don't feel terrible about drastically changing the ergonomics of the tool at this point. I'd considered allowing custom templates, but I'm thinking it might be smarter to make a handful of custom templates that handle most common cases. This way, I can use the template flag to carry the right context down and fetch only what the user wants to see.
The text was updated successfully, but these errors were encountered:
I've got to figure out a meaningful way to allow injection of file/line references. What makes this difficult is that it requires either two bulk calls (one to tasks and one to comments, which hold the inline info when present) or an individual comment API call per unresolved task.
I think, however, that bulk fetching comments is probably more likely to be faster and more API-economical in the general case. Obviously there's exceptions for PRs with 50 pages of comments but 2 open tasks; you're making 50 comment API hits per task sync versus 2.
Then there's the question of how to integrate it into existing behavior. I've got 2 watchers, and I'm at 0.0.4, so I don't feel terrible about drastically changing the ergonomics of the tool at this point. I'd considered allowing custom templates, but I'm thinking it might be smarter to make a handful of custom templates that handle most common cases. This way, I can use the template flag to carry the right context down and fetch only what the user wants to see.
The text was updated successfully, but these errors were encountered: