From 4dfd47a9310918ff7967f0e6fa4e5d06c3c68952 Mon Sep 17 00:00:00 2001
From: mhdSid <mohdsidani@gmail.com>
Date: Thu, 26 Jan 2017 18:07:03 +0200
Subject: [PATCH 1/9] Add the ability to append <audio> tag in the DOM so a
 song can be played instantly when loading it from the server without any
 error - on mobile devices

Without clicking twice on the element
---
 script/soundmanager2.js | 27 ++++++++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)

diff --git a/script/soundmanager2.js b/script/soundmanager2.js
index e71e64f9..53b7c87c 100644
--- a/script/soundmanager2.js
+++ b/script/soundmanager2.js
@@ -646,6 +646,26 @@ function SoundManager(smURL, smID) {
 
   };
 
+  /**
+   * Creates a <div> element wrapper and an <audio> element inside it
+   *
+   * @return {HTMLAudioElement} The audio element created in the dom
+   */
+  this.createAudioElement = function () {
+
+    try {
+      var d = doc.createElement('div');
+      var a = doc.createElement('audio');
+      d.id = 'sm2-html5Audio-wrapper';
+      a.id = 'sm2-html5Audio-tag';
+      d.appendChild(a);
+      doc.body.appendChild(d);
+    } catch (e) {} finally {
+      return a;
+    }
+    
+  }
+
   /**
    * Calls the unload() method of a SMSound object by ID.
    *
@@ -2141,7 +2161,7 @@ function SoundManager(smURL, smID) {
 
             sm2._wD(s.id + ': Cloning Audio() for instance #' + s.instanceCount + '...');
 
-            audioClone = new Audio(s._iO.url);
+            audioClone = (mobileHTML5) ? this.createAudioElement() : new Audio(s._iO.url);
 
             onended = function() {
               event.remove(audioClone, 'ended', onended);
@@ -3096,13 +3116,14 @@ function SoundManager(smURL, smID) {
 
         if (instanceOptions.autoLoad || instanceOptions.autoPlay) {
 
-          s._a = new Audio(instanceOptions.url);
+          s._a = (mobileHTML5) ? this.createAudioElement() : new Audio(instanceOptions.url);
+
           s._a.load();
 
         } else {
 
           // null for stupid Opera 9.64 case
-          s._a = (isOpera && opera.version() < 10 ? new Audio(null) : new Audio());
+          s._a = (mobileHTML5) ? this.createAudioElement() : (isOpera && opera.version() < 10 ? new Audio(null) : new Audio());
 
         }
 

From 778a3eeee7851ddb1ac4c27b0cab7e32b0eb102f Mon Sep 17 00:00:00 2001
From: mhdSid <mohdsidani@gmail.com>
Date: Thu, 26 Jan 2017 23:33:59 +0200
Subject: [PATCH 2/9] refactor

---
 script/soundmanager2.js | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/script/soundmanager2.js b/script/soundmanager2.js
index 53b7c87c..a98bb722 100644
--- a/script/soundmanager2.js
+++ b/script/soundmanager2.js
@@ -654,16 +654,14 @@ function SoundManager(smURL, smID) {
   this.createAudioElement = function () {
 
     try {
-      var d = doc.createElement('div');
-      var a = doc.createElement('audio');
+      var d = doc.createElement('div'),
+          a = doc.createElement('audio');
       d.id = 'sm2-html5Audio-wrapper';
-      a.id = 'sm2-html5Audio-tag';
-      d.appendChild(a);
-      doc.body.appendChild(d);
+      a.id = 'sm2-html5Audio';
     } catch (e) {} finally {
       return a;
     }
-    
+
   }
 
   /**

From 345bb8721d9f6a84e71620e6ce2804221c66f8c8 Mon Sep 17 00:00:00 2001
From: mhdSid <mohdsidani@gmail.com>
Date: Thu, 26 Jan 2017 23:36:05 +0200
Subject: [PATCH 3/9] add nested append functions

---
 script/soundmanager2.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/script/soundmanager2.js b/script/soundmanager2.js
index a98bb722..1f3c61c1 100644
--- a/script/soundmanager2.js
+++ b/script/soundmanager2.js
@@ -658,6 +658,7 @@ function SoundManager(smURL, smID) {
           a = doc.createElement('audio');
       d.id = 'sm2-html5Audio-wrapper';
       a.id = 'sm2-html5Audio';
+      doc.body.appendChild(d).appendChild(a);
     } catch (e) {} finally {
       return a;
     }

From 7224698c5f60b12dea48c1ff9c66196b6858f174 Mon Sep 17 00:00:00 2001
From: mhdSid <mohdsidani@gmail.com>
Date: Fri, 27 Jan 2017 15:09:29 +0200
Subject: [PATCH 4/9] add audio src

---
 script/soundmanager2.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/script/soundmanager2.js b/script/soundmanager2.js
index 1f3c61c1..87e6b421 100644
--- a/script/soundmanager2.js
+++ b/script/soundmanager2.js
@@ -651,18 +651,19 @@ function SoundManager(smURL, smID) {
    *
    * @return {HTMLAudioElement} The audio element created in the dom
    */
-  this.createAudioElement = function () {
+  this.createAudioElement = function (src) {
 
     try {
       var d = doc.createElement('div'),
           a = doc.createElement('audio');
       d.id = 'sm2-html5Audio-wrapper';
       a.id = 'sm2-html5Audio';
+      a.src = (src) ? src : '';
       doc.body.appendChild(d).appendChild(a);
     } catch (e) {} finally {
       return a;
     }
-
+    
   }
 
   /**
@@ -2160,7 +2161,7 @@ function SoundManager(smURL, smID) {
 
             sm2._wD(s.id + ': Cloning Audio() for instance #' + s.instanceCount + '...');
 
-            audioClone = (mobileHTML5) ? this.createAudioElement() : new Audio(s._iO.url);
+            audioClone = (mobileHTML5) ? this.createAudioElement(s._iO.url) : new Audio(s._iO.url);
 
             onended = function() {
               event.remove(audioClone, 'ended', onended);
@@ -3115,7 +3116,7 @@ function SoundManager(smURL, smID) {
 
         if (instanceOptions.autoLoad || instanceOptions.autoPlay) {
 
-          s._a = (mobileHTML5) ? this.createAudioElement() : new Audio(instanceOptions.url);
+          s._a = (mobileHTML5) ? this.createAudioElement(instanceOptions.url) : new Audio(instanceOptions.url);
 
           s._a.load();
 

From a71bd9d2a4b4f32ff72c2199861aa61567154778 Mon Sep 17 00:00:00 2001
From: mhdSid <mohdsidani@gmail.com>
Date: Fri, 27 Jan 2017 16:18:24 +0200
Subject: [PATCH 5/9] use sm2 instead of this

---
 script/soundmanager2.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/script/soundmanager2.js b/script/soundmanager2.js
index 87e6b421..5020e7b8 100644
--- a/script/soundmanager2.js
+++ b/script/soundmanager2.js
@@ -2161,7 +2161,7 @@ function SoundManager(smURL, smID) {
 
             sm2._wD(s.id + ': Cloning Audio() for instance #' + s.instanceCount + '...');
 
-            audioClone = (mobileHTML5) ? this.createAudioElement(s._iO.url) : new Audio(s._iO.url);
+            audioClone = (mobileHTML5) ? sm2.createAudioElement(s._iO.url) : new Audio(s._iO.url);
 
             onended = function() {
               event.remove(audioClone, 'ended', onended);
@@ -3116,14 +3116,14 @@ function SoundManager(smURL, smID) {
 
         if (instanceOptions.autoLoad || instanceOptions.autoPlay) {
 
-          s._a = (mobileHTML5) ? this.createAudioElement(instanceOptions.url) : new Audio(instanceOptions.url);
+          s._a = (mobileHTML5) ? sm2.createAudioElement(instanceOptions.url) : new Audio(instanceOptions.url);
 
           s._a.load();
 
         } else {
 
           // null for stupid Opera 9.64 case
-          s._a = (mobileHTML5) ? this.createAudioElement() : (isOpera && opera.version() < 10 ? new Audio(null) : new Audio());
+          s._a = (mobileHTML5) ? sm2.createAudioElement() : (isOpera && opera.version() < 10 ? new Audio(null) : new Audio());
 
         }
 

From 74b46dd41bd475c74d1c6dabd6f79f3d027d2797 Mon Sep 17 00:00:00 2001
From: mhdSid <mohdsidani@gmail.com>
Date: Fri, 27 Jan 2017 18:51:59 +0200
Subject: [PATCH 6/9] get already existing tag from the DOM

---
 script/soundmanager2.js | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)

diff --git a/script/soundmanager2.js b/script/soundmanager2.js
index 5020e7b8..75d8afdd 100644
--- a/script/soundmanager2.js
+++ b/script/soundmanager2.js
@@ -647,24 +647,17 @@ function SoundManager(smURL, smID) {
   };
 
   /**
-   * Creates a <div> element wrapper and an <audio> element inside it
+   * Gets the <audio> element that already exists in the DOM
    *
    * @return {HTMLAudioElement} The audio element created in the dom
    */
-  this.createAudioElement = function (src) {
+   this.getAudioTagElement = function(src) {
 
-    try {
-      var d = doc.createElement('div'),
-          a = doc.createElement('audio');
-      d.id = 'sm2-html5Audio-wrapper';
-      a.id = 'sm2-html5Audio';
-      a.src = (src) ? src : '';
-      doc.body.appendChild(d).appendChild(a);
-    } catch (e) {} finally {
-      return a;
-    }
-    
-  }
+    var a = doc.getElementById('sm2-html5Audio');
+    a.src = (src) ? src : '';
+    return a;
+
+   };
 
   /**
    * Calls the unload() method of a SMSound object by ID.
@@ -2161,7 +2154,7 @@ function SoundManager(smURL, smID) {
 
             sm2._wD(s.id + ': Cloning Audio() for instance #' + s.instanceCount + '...');
 
-            audioClone = (mobileHTML5) ? sm2.createAudioElement(s._iO.url) : new Audio(s._iO.url);
+            audioClone = (mobileHTML5) ? sm2.getAudioTagElement(s._iO.url) : new Audio(s._iO.url);
 
             onended = function() {
               event.remove(audioClone, 'ended', onended);
@@ -3116,14 +3109,14 @@ function SoundManager(smURL, smID) {
 
         if (instanceOptions.autoLoad || instanceOptions.autoPlay) {
 
-          s._a = (mobileHTML5) ? sm2.createAudioElement(instanceOptions.url) : new Audio(instanceOptions.url);
+          s._a = (mobileHTML5) ? sm2.getAudioTagElement(instanceOptions.url) : new Audio(instanceOptions.url);
 
           s._a.load();
 
         } else {
 
           // null for stupid Opera 9.64 case
-          s._a = (mobileHTML5) ? sm2.createAudioElement() : (isOpera && opera.version() < 10 ? new Audio(null) : new Audio());
+          s._a = (mobileHTML5) ? sm2.getAudioTagElement() : (isOpera && opera.version() < 10 ? new Audio(null) : new Audio());
 
         }
 

From 418086f1ebc490f991aeef9cf1361407d9174c09 Mon Sep 17 00:00:00 2001
From: mhdSid <mohdsidani@gmail.com>
Date: Fri, 27 Jan 2017 19:47:35 +0200
Subject: [PATCH 7/9] add condition

---
 script/soundmanager2.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/script/soundmanager2.js b/script/soundmanager2.js
index 75d8afdd..47927c63 100644
--- a/script/soundmanager2.js
+++ b/script/soundmanager2.js
@@ -4337,7 +4337,7 @@ function SoundManager(smURL, smID) {
     }
 
     // double-whammy: Opera 9.64 throws WRONG_ARGUMENTS_ERR if no parameter passed to Audio(), and Webkit + iOS happily tries to load "null" as a URL. :/
-    var a = (Audio !== _undefined ? (isOpera && opera.version() < 10 ? new Audio(null) : new Audio()) : null),
+    var a = (mobileHTML5) ? sm2.getAudioTagElement() : (Audio !== _undefined ? (isOpera && opera.version() < 10 ? new Audio(null) : new Audio()) : null),
         item, lookup, support = {}, aF, i;
 
     function cp(m) {

From 916ef06e5d33b35a2ad68f0a0aafd9438a1cf0b4 Mon Sep 17 00:00:00 2001
From: mhdSid <mohdsidani@gmail.com>
Date: Sat, 28 Jan 2017 14:36:10 +0200
Subject: [PATCH 8/9] reuse the create audio element function

---
 script/soundmanager2.js | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/script/soundmanager2.js b/script/soundmanager2.js
index 47927c63..30d284b7 100644
--- a/script/soundmanager2.js
+++ b/script/soundmanager2.js
@@ -647,17 +647,24 @@ function SoundManager(smURL, smID) {
   };
 
   /**
-   * Gets the <audio> element that already exists in the DOM
+   * Create the <audio> element in the DOM
    *
    * @return {HTMLAudioElement} The audio element created in the dom
    */
-   this.getAudioTagElement = function(src) {
+   this.createAudioElement = function (src) {
 
-    var a = doc.getElementById('sm2-html5Audio');
-    a.src = (src) ? src : '';
-    return a;
+    try {
+      var d = doc.createElement('div'),
+          a = doc.createElement('audio');
+      d.id = 'sm2-html5Audio-wrapper';
+      a.id = 'sm2-html5Audio';
+      a.src = (src) ? src : '';
+      doc.body.appendChild(d).appendChild(a);
+    } catch (e) {} finally {
+      return a;
+    }
 
-   };
+  };
 
   /**
    * Calls the unload() method of a SMSound object by ID.
@@ -2154,7 +2161,7 @@ function SoundManager(smURL, smID) {
 
             sm2._wD(s.id + ': Cloning Audio() for instance #' + s.instanceCount + '...');
 
-            audioClone = (mobileHTML5) ? sm2.getAudioTagElement(s._iO.url) : new Audio(s._iO.url);
+            audioClone = (mobileHTML5) ? sm2.createAudioElement(s._iO.url) : new Audio(s._iO.url);
 
             onended = function() {
               event.remove(audioClone, 'ended', onended);
@@ -3109,14 +3116,14 @@ function SoundManager(smURL, smID) {
 
         if (instanceOptions.autoLoad || instanceOptions.autoPlay) {
 
-          s._a = (mobileHTML5) ? sm2.getAudioTagElement(instanceOptions.url) : new Audio(instanceOptions.url);
+          s._a = (mobileHTML5) ? sm2.createAudioElement(instanceOptions.url) : new Audio(instanceOptions.url);
 
           s._a.load();
 
         } else {
 
           // null for stupid Opera 9.64 case
-          s._a = (mobileHTML5) ? sm2.getAudioTagElement() : (isOpera && opera.version() < 10 ? new Audio(null) : new Audio());
+          s._a = (mobileHTML5) ? sm2.createAudioElement() : (isOpera && opera.version() < 10 ? new Audio(null) : new Audio());
 
         }
 
@@ -4337,7 +4344,7 @@ function SoundManager(smURL, smID) {
     }
 
     // double-whammy: Opera 9.64 throws WRONG_ARGUMENTS_ERR if no parameter passed to Audio(), and Webkit + iOS happily tries to load "null" as a URL. :/
-    var a = (mobileHTML5) ? sm2.getAudioTagElement() : (Audio !== _undefined ? (isOpera && opera.version() < 10 ? new Audio(null) : new Audio()) : null),
+    var a = (mobileHTML5) ? sm2.createAudioElement() : (Audio !== _undefined ? (isOpera && opera.version() < 10 ? new Audio(null) : new Audio()) : null),
         item, lookup, support = {}, aF, i;
 
     function cp(m) {

From e0fad36d468a1ff9dfc48eeaa54442b931833a2f Mon Sep 17 00:00:00 2001
From: mhdSid <mohdsidani@gmail.com>
Date: Sat, 28 Jan 2017 14:55:22 +0200
Subject: [PATCH 9/9] remove the element creation from the test function

---
 script/soundmanager2.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/script/soundmanager2.js b/script/soundmanager2.js
index 30d284b7..32eb4288 100644
--- a/script/soundmanager2.js
+++ b/script/soundmanager2.js
@@ -4344,7 +4344,7 @@ function SoundManager(smURL, smID) {
     }
 
     // double-whammy: Opera 9.64 throws WRONG_ARGUMENTS_ERR if no parameter passed to Audio(), and Webkit + iOS happily tries to load "null" as a URL. :/
-    var a = (mobileHTML5) ? sm2.createAudioElement() : (Audio !== _undefined ? (isOpera && opera.version() < 10 ? new Audio(null) : new Audio()) : null),
+    var a = (Audio !== _undefined ? (isOpera && opera.version() < 10 ? new Audio(null) : new Audio()) : null),
         item, lookup, support = {}, aF, i;
 
     function cp(m) {