Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why can't there just be an upsert method on Document? #103

Open
lurchpop opened this issue Apr 11, 2017 · 0 comments
Open

Why can't there just be an upsert method on Document? #103

lurchpop opened this issue Apr 11, 2017 · 0 comments

Comments

@lurchpop
Copy link

lurchpop commented Apr 11, 2017

What's the reason Document can't have this method?

	static upsert(query, update){
		return this.findOne(query).then(doc=>{
			return Object.assign(doc, update).save();
		});
	}

Why the findOneAndUpdate(.., .., {upsert:true}) garbage where the save hooks don't even get called?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant