Skip to content

Commit 92324b5

Browse files
committed
Ensure that Ext Game Popup sends Affirmative and Negative Flags
`On Dialog Start` (used in SCPUI and within `popup_init`) reads popup options by affirmative or negative flags, and the popup for exiting the Mainhall did not set these flags. Notably, most popups that use `POPUP_NO` or `POPUP_YES` already, so this PR sets those flags for this popup. Now `On Dialog Start` within `popup_init` has access to the correct flags. PR tested and works as expected, both in retail UI and SCPUI
1 parent 1c82141 commit 92324b5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

code/menuui/mainhallmenu.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -695,7 +695,7 @@ void main_hall_exit_game()
695695
// stop music first
696696
main_hall_stop_music(true);
697697
main_hall_stop_ambient();
698-
choice = popup( PF_NO_NETWORKING | PF_BODY_BIG, 2, POPUP_NO, POPUP_YES, XSTR( "Exit Game?", 365));
698+
choice = popup( PF_NO_NETWORKING | PF_BODY_BIG | PF_USE_NEGATIVE_ICON | PF_USE_AFFIRMATIVE_ICON, 2, POPUP_NO, POPUP_YES, XSTR( "Exit Game?", 365));
699699
if (choice == 1) {
700700
gameseq_post_event(GS_EVENT_QUIT_GAME);
701701
} else {

0 commit comments

Comments
 (0)