Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QtFRED dialog delete-on-close #6457

Open
Goober5000 opened this issue Dec 12, 2024 · 3 comments
Open

QtFRED dialog delete-on-close #6457

Goober5000 opened this issue Dec 12, 2024 · 3 comments
Assignees
Labels
bug An issue from unintended consequences qtfred A feature or issue related to qtFred.

Comments

@Goober5000
Copy link
Contributor

From PR #6322:

Set the delete-on-close attribute via diag->setAttribute(Qt::WA_DeleteOnClose);

Many dialogs in qtFRED are allocated with new but never freed with delete, causing memory leaks until the program is closed. Adding delete-on-close should fix the memory leaks, according to what I've found by searching online.

@Goober5000 Goober5000 added bug An issue from unintended consequences qtfred A feature or issue related to qtFred. labels Dec 12, 2024
@github-project-automation github-project-automation bot moved this to Open Tasks in qtFRED2 Dec 12, 2024
TheForce172 added a commit to TheForce172/fs2open.github.com that referenced this issue Dec 13, 2024
@Goober5000
Copy link
Contributor Author

@TheForce172 It looks like I can't actually assign a ticket to you until you have some activity on it. Post a comment and that should be enough, as it was on #6456.

@TheForce172
Copy link
Contributor

That seems a bit unintuitive design.

@Goober5000
Copy link
Contributor Author

¯⁠\⁠_⁠(⁠ツ⁠)⁠_⁠/⁠¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue from unintended consequences qtfred A feature or issue related to qtFred.
Projects
Status: Open Tasks
Development

No branches or pull requests

2 participants