Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coherent name for AUTOEXTRACT_USER #14

Open
ivanprado opened this issue Aug 24, 2020 · 1 comment
Open

Coherent name for AUTOEXTRACT_USER #14

ivanprado opened this issue Aug 24, 2020 · 1 comment

Comments

@ivanprado
Copy link
Contributor

Current names:

scrapy-autoextract -> AUTOEXTRACT_USER
scrapinghub-autoextract -> SCRAPINGHUB_AUTOEXTRACT_KEY

It would be nice to be coherent around the different libraries and the API itself. The API seems to use key https://doc.scrapinghub.com/autoextract.html. So probably better to use KEY instead of USER. And then there is a question regarding if using SCRAPINGHUB_AUTOEXTRACT or just AUTOEXTRACT and even if this could be different per library.

@victor-torres
Copy link
Contributor

Thank you for creating this issue, @ivanprado.

My personal suggestion is to rename from AUTOEXTRACT_USER to AUTOEXTRACT_KEY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants