Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware priority #31

Open
ejulio opened this issue May 22, 2020 · 1 comment
Open

Middleware priority #31

ejulio opened this issue May 22, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ejulio
Copy link

ejulio commented May 22, 2020

What should be the middleware priority?
Should it be the first/last one or can it be anywhere else?
Probably, we should add a note in documentation about the possible side effects of the middleware so the user is aware of where it should be placed

@Gallaecio Gallaecio added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 9, 2022
@Gallaecio
Copy link
Member

What should be the middleware priority?
Should it be the first/last one or can it be anywhere else?

I feel like this has been addressed since 6714d4a started asking to use 543. Even if it looks like an example value not to be copied as is, it has been the de facto value used everywhere, with no issues that I am aware of.

Probably, we should add a note in documentation about the possible side effects of the middleware so the user is aware of where it should be placed.

Given the name is InjectionMiddleware, its side-effect is resolving dependency injection, and the only reason you might worry about the placement of this middleware is in scenarios where you override callbacks (you might want to do that before this middleware), I am not sure if we need to elaborate in the docs. Not a strong opinion, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants