Skip to content

Commit aad8ae6

Browse files
committed
update doc examples for RequestUrl/ResponseUrl
1 parent ba4e615 commit aad8ae6

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

docs/advanced/additional-requests.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ a generic HTTP Request: :class:`~.HttpRequest`. Here's an example:
5454
).encode("utf-8"),
5555
)
5656
57-
print(request.url) # https://www.api.example.com/product-pagination/
57+
print(request.url) # RequestUrl('https://www.api.example.com/product-pagination/')
5858
print(request.method) # POST
5959
6060
print(type(request.headers) # <class 'web_poet.page_inputs.HttpRequestHeaders'>
@@ -90,7 +90,7 @@ it's perfectly fine to define them as:
9090
9191
request = web_poet.HttpRequest("https://api.example.com/product-info?id=123")
9292
93-
print(request.url) # https://api.example.com/product-info?id=123
93+
print(request.url) # RequestUrl('https://api.example.com/product-info?id=123')
9494
print(request.method) # GET
9595
9696
print(type(request.headers) # <class 'web_poet.page_inputs.HttpRequestHeaders'>
@@ -141,7 +141,7 @@ Let's check out an example to see its internals:
141141
headers={"Content-Type": "application/json;charset=UTF-8"}
142142
)
143143
144-
print(response.url) # https://www.api.example.com/product-pagination/
144+
print(response.url) # ResponseUrl('https://www.api.example.com/product-pagination/')
145145
print(type(response.url)) # <class 'str'>
146146
147147
print(response.body) # b'{"data": "value \xf0\x9f\x91\x8d"}'
@@ -604,7 +604,7 @@ from the previous subsection named: :ref:`httpclient-get-example`.
604604
except web_poet.exceptions.HttpResponseError as err:
605605
logger.warning(
606606
f"Received a {err.response.status} response status for product ID "
607-
f"'{item['product_id']}' from this URL: {err.request.url}"
607+
f"'{item['product_id']}' from this URL: {str(err.request.url)}"
608608
)
609609
else:
610610
item["images"] = response.css(".product-images img::attr(src)").getall()

docs/intro/from-ground-up.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ For example, a very basic Page Object could look like this:
503503
504504
def to_item(self) -> dict:
505505
return {
506-
'url': self.response.url,
506+
'url': str(self.response.url),
507507
'title': self.response.css("h1::text").get()
508508
}
509509

0 commit comments

Comments
 (0)