Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untangle redux state for www + gui #1801

Closed
chrisgarrity opened this issue Feb 2, 2018 · 1 comment
Closed

Untangle redux state for www + gui #1801

chrisgarrity opened this issue Feb 2, 2018 · 1 comment
Assignees
@colbygk @chrisgarrity @paulkaplan @rschamp
Milestone
February 2018

Comments

@chrisgarrity
Copy link
Contributor

Review current state of redux+react modularity:
reduxjs/react-redux#278

Figure out how we're going to deal with redux state with www, gui, and paint.
@chrisgarrity chrisgarrity added this to the February 2018 milestone Feb 2, 2018
@chrisgarrity
Copy link
Contributor Author

After discussion, we realized that the Intl object was causing the pain (thanks @fsih). So trying a new approach where GUI can accept an intl prop (optional) instead of expecting the intl to be available via redux state. See scratchfoundation/scratch-gui#1448

Closing this issue, as the remaining work will be tracked in scratchfoundation/scratch-gui#1336.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colbygk colbygk

@chrisgarrity chrisgarrity

@paulkaplan paulkaplan

@rschamp rschamp

Labels
None yet
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
4 participants
@colbygk @chrisgarrity @paulkaplan @rschamp