Skip to content

Conversation

cwillisf
Copy link
Contributor

Resolves:

  • Resolves POD-299

Changes:

Add a property on SplashPresentation called shouldShowCommunityRows, which controls whether or not the community-driven homepage rows should be shown.

Test Coverage:

SplashPresentation was not previously under test, so I added a quick unit test for just this feature. More would be better, of course...

@cwillisf cwillisf force-pushed the toggle-community-rows branch 3 times, most recently from 88f3c77 to baaa78c Compare September 25, 2025 14:09
@cwillisf cwillisf force-pushed the toggle-community-rows branch from baaa78c to 1b9d643 Compare September 25, 2025 16:18
@cwillisf cwillisf marked this pull request as ready for review September 25, 2025 16:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a feature flag to control the visibility of community-driven homepage rows in the Scratch application. It introduces a shouldShowCommunityRows property that determines whether "What the Community is Remixing" and "What the Community is Loving" sections are displayed on the splash page.

  • Added shouldShowCommunityRows boolean property to SplashPresentation component
  • Wrapped existing community rows in conditional rendering logic
  • Added comprehensive unit tests for the new functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/views/splash/presentation.jsx Added conditional rendering for community rows based on new prop
test/unit/components/splash-presentation.test.jsx Added unit tests to verify community rows visibility toggle

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rosics-code
Copy link

rosics-code commented Sep 27, 2025

Would us (the Scratchers) be able to toggle it? And if so, will it save?

@cwillisf
Copy link
Contributor Author

Would us (the Scratchers) be able to toggle it? And if so, will it save?

Good question! This is a build-time toggle so that scratch-www can be built for different situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants