🎨 修复eslint问题

Author: CodFrm

.github/workflows/test.yaml

@@ -23,9 +23,14 @@ jobs:
           node-version: 22
           cache: 'pnpm'
 
+      - name: Install dependencies
+        run: pnpm i --frozen-lockfile
+
+      - name: Lint
+        run: pnpm run lint
+
       - name: Unit Test
         run: |
-          pnpm i --frozen-lockfile
           pnpm test
           pnpm run coverage
 

eslint.config.mjs

@@ -4,13 +4,17 @@ import reactHooks from "eslint-plugin-react-hooks";
 import reactJsx from "eslint-plugin-react/configs/jsx-runtime.js";
 import react from "eslint-plugin-react/configs/recommended.js";
 import ts from "typescript-eslint";
+import globals from "globals";
 
 export default [
   {
-    env: {
-      browser: true,
-      es2020: true,
-      webextensions: true,
+    languageOptions: {
+      ecmaVersion: 2020,
+      sourceType: "module",
+      globals: {
+        ...globals.browser,
+        ...globals.webextensions,
+      },
     },
   },
   js.configs.recommended,
@@ -32,8 +36,17 @@ export default [
       "@typescript-eslint/no-explicit-any": "off",
       "@typescript-eslint/ban-ts-comment": "off",
       "@typescript-eslint/no-unused-expressions": "off",
+      "@typescript-eslint/consistent-type-imports": "error",
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          "argsIgnorePattern": "^_",
+          "varsIgnorePattern": "^_",
+          "caughtErrorsIgnorePattern": "^_"
+        }
+      ],
       ...reactHooks.configs.recommended.rules,
     },
   },
-  { ignores: ["dist/"] },
+  { ignores: ["dist/", "example/"] },
 ];

packages/chrome-extension-mock/downloads.ts

@@ -1,5 +1,5 @@
 export default class Downloads {
-  download(_: any, callback: Function) {
+  download(_: any, callback: () => void) {
     callback && callback();
   }
 }

packages/chrome-extension-mock/web_reqeuest.ts

@@ -1,14 +1,8 @@
 export default class WebRequest {
-  sendHeader?: (
-    details: chrome.webRequest.WebRequestHeadersDetails
-  ) => chrome.webRequest.BlockingResponse | void;
+  sendHeader?: (details: chrome.webRequest.OnSendHeadersDetails) => chrome.webRequest.BlockingResponse | void;
 
   mockXhr(xhr: any): any {
-    // eslint-disable-next-line no-underscore-dangle
-    const _this = this;
-    // eslint-disable-next-line func-names
-    return function () {
-      // eslint-disable-next-line new-cap
+    return () => {
       const ret = new xhr();
       const header: chrome.webRequest.HttpHeader[] = [];
       ret.setRequestHeader = (k: string, v: string) => {
@@ -23,14 +17,13 @@ export default class WebRequest {
           name: "cookie",
           value: "website=example.com",
         });
-        const resp = _this.sendHeader?.({
+        const resp = this.sendHeader?.({
           method: ret.method,
           url: ret.url,
           requestHeaders: header,
           initiator: chrome.runtime.getURL(""),
-        } as chrome.webRequest.WebRequestHeadersDetails) as chrome.webRequest.BlockingResponse;
+        } as chrome.webRequest.OnSendHeadersDetails) as chrome.webRequest.BlockingResponse;
         resp.requestHeaders?.forEach((h) => {
-          // eslint-disable-next-line no-underscore-dangle
           ret._authorRequestHeaders!.addHeader(h.name, h.value);
         });
         oldSend(data);

packages/cloudscript/cloudscript.ts

@@ -1,5 +1,5 @@
-import { Script } from "@App/app/repo/scripts";
-import { Value } from "@App/app/repo/value";
+import type { Script } from "@App/app/repo/scripts";
+import type { Value } from "@App/app/repo/value";
 import { valueClient } from "@App/pages/store/features/script";
 
 export type ExportCookies = {

packages/cloudscript/factory.ts

@@ -1,5 +1,5 @@
-import { ExportTarget } from "@App/app/repo/export";
-import { ExportParams } from "./cloudscript";
+import type { ExportTarget } from "@App/app/repo/export";
+import type { ExportParams } from "./cloudscript";
 import LocalCloudScript from "./local";
 
 export interface CloudScriptParams {

packages/cloudscript/local.ts

@@ -1,11 +1,12 @@
 import { ExtVersion } from "@App/app/const";
-import { Script } from "@App/app/repo/scripts";
-import { Value } from "@App/app/repo/value";
-import JSZip from "jszip";
+import type { Script } from "@App/app/repo/scripts";
+import type { Value } from "@App/app/repo/value";
+import type JSZip from "jszip";
 import packageTpl from "@App/template/cloudcat-package/package.tpl";
 import utilsTpl from "@App/template/cloudcat-package/utils.tpl";
 import indexTpl from "@App/template/cloudcat-package/index.tpl";
-import CloudScript, { ExportCookies, ExportParams } from "./cloudscript";
+import type { ExportCookies, ExportParams } from "./cloudscript";
+import type CloudScript from "./cloudscript";
 
 // 导出到本地,一个可执行到npm包
 export default class LocalCloudScript implements CloudScript {

packages/eslint/compat-grant.js

@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-require-imports */
+/* eslint-disable no-undef */
 const compat_grant = require("eslint-plugin-userscripts/dist/data/compat-grant.js");
 const compatMap = {
   CAT_userConfig: [{ type: "scriptcat", versionConstraint: ">=0.11.0-beta" }],

packages/eslint/compat-headers.js

@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-require-imports */
+/* eslint-disable no-undef */
 const compat_headers = require("eslint-plugin-userscripts/dist/data/compat-headers.js");
 
 const compatMap = {

packages/eslint/linter-config.ts

@@ -1,4 +1,5 @@
-const { configs, rules } = require("eslint-plugin-userscripts");
+/* eslint-disable @typescript-eslint/no-require-imports */
+const { configs } = require("eslint-plugin-userscripts");
 
 // 默认规则
 const config = {