Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra Stress not working on Java 15+ #36

Open
CodeLieutenant opened this issue Dec 17, 2024 · 8 comments
Open

Cassandra Stress not working on Java 15+ #36

CodeLieutenant opened this issue Dec 17, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@CodeLieutenant
Copy link
Collaborator

Java 15 removed Nashorn engine, and due to this, cassandra-stress is not working on modern Java versions

@CodeLieutenant CodeLieutenant added the bug Something isn't working label Dec 17, 2024
@CodeLieutenant CodeLieutenant self-assigned this Dec 17, 2024
@mykaul
Copy link

mykaul commented Dec 18, 2024

It is continued separately - see https://mvnrepository.com/artifact/org.openjdk.nashorn/nashorn-core

@fruch
Copy link

fruch commented Dec 18, 2024

@CodeLieutenant

what's c-s is doing with this engine ? I don't remember any feature we are using and passing into it javascript...

@CodeLieutenant
Copy link
Collaborator Author

@fruch, since this is a Apache Cassandra Codebase (I've remove much of it's source code), there is a possibility in it to define UDFs in Javascript. Thats executed with Nashorn engine, and since c-s is derived from Cassandra's source code, it also does depend on JS engine. There is no scripting available to c-s, but it's really hard to remove it from the source code.

@fruch
Copy link

fruch commented Dec 18, 2024

@fruch, since this is a Apache Cassandra Codebase (I've remove much of it's source code), there is a possibility in it to define UDFs in Javascript. Thats executed with Nashorn engine, and since c-s is derived from Cassandra's source code, it also does depend on JS engine. There is no scripting available to c-s, but it's really hard to remove it from the source code.

Why it's hard, if we don't have any functionality in c-s using it directly ?

@fruch
Copy link

fruch commented Dec 18, 2024

I rather invest in taking it out of the code, then invest in replacing the library

@CodeLieutenant
Copy link
Collaborator Author

CodeLieutenant commented Dec 18, 2024

I was thinking the same, removing it would be great if it's possible, replacing the library can be a temporary fix if needed.
But good solution is to remove it completly

@CodeLieutenant
Copy link
Collaborator Author

Why it's hard, if we don't have any functionality in c-s using it directly ?

Cause c-s is using Apache Cassandra as a base, so other classes are referencing the Nashorn and so on, Dep Tree, this make is really hard to remove it

@fruch
Copy link

fruch commented Dec 18, 2024

Why it's hard, if we don't have any functionality in c-s using it directly ?

Cause c-s is using Apache Cassandra as a base, so other classes are referencing the Nashorn and so on, Dep Tree, this make is really hard to remove it

It's mentioned only in two files, I think it should be that hard.

Anyhow there is no rush for supporting newer java versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants