Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile on Windows #130

Open
mykaul opened this issue Jun 13, 2024 · 8 comments
Open

Compile on Windows #130

mykaul opened this issue Jun 13, 2024 · 8 comments

Comments

@mykaul
Copy link

mykaul commented Jun 13, 2024

We should use GH action and make sure this compiles on Windows as well.

@Lorak-mmk
Copy link
Collaborator

Our fork of original cpp-driver didn't support Windows afaik so it's not a compatibility issue. Is there a specific reason for this change / client request etc?
Drivers are usually used server-side which is dominated by linux. Is there any other driver apart from python-driver where we test Windows in CI?
I have very bad memories from trying to use windows in CI for C++ projetcs, and in general from trying to maintain Windows compatibility.
While this project is mostly Rust there is still a fair share of C++ code. I fear the moment when we would need to debug and fix some windows-specific issue...

@mykaul
Copy link
Author

mykaul commented Jun 18, 2024

Customer request. See PRs on the previous CPP driver.

@Lorak-mmk
Copy link
Collaborator

Do you know the use case of this customer? Do they use Windows Server for Scylla clients?

@Lorak-mmk
Copy link
Collaborator

Scylla itself doesn't support Windows (but that would be a "fun" hackathon project :D ), so it can only be an issue in environment where some servers run Linux and some run Windows Server - I'm curious why that would be the case.

@mykaul
Copy link
Author

mykaul commented Jun 18, 2024

Scylla itself doesn't support Windows (but that would be a "fun" hackathon project :D ), so it can only be an issue in environment where some servers run Linux and some run Windows Server - I'm curious why that would be the case.

Why won't the client run on Windows?

@mykaul
Copy link
Author

mykaul commented Jun 26, 2024

See scylladb/cpp-driver#83 for ref from the old driver.

@Lorak-mmk
Copy link
Collaborator

Scylla itself doesn't support Windows (but that would be a "fun" hackathon project :D ), so it can only be an issue in environment where some servers run Linux and some run Windows Server - I'm curious why that would be the case.

Why won't the client run on Windows?

You mean the end-application that runs on some untrusted users PC? Because that would require such user to have access to the database.

@mykaul
Copy link
Author

mykaul commented Jun 26, 2024

Scylla itself doesn't support Windows (but that would be a "fun" hackathon project :D ), so it can only be an issue in environment where some servers run Linux and some run Windows Server - I'm curious why that would be the case.

Why won't the client run on Windows?

You mean the end-application that runs on some untrusted users PC? Because that would require such user to have access to the database.

I have no idea if it's trusted or not. It's not different than a Linux client. It's a different OS, that some people actually use - and may need access to Scylla from it. Probably some Windows Server edition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants