Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation stage to the 1-1 restore service #4201

Open
karol-kokoszka opened this issue Jan 13, 2025 · 0 comments
Open

Add validation stage to the 1-1 restore service #4201

karol-kokoszka opened this issue Jan 13, 2025 · 0 comments
Assignees
@VAveryanov8
Milestone
1-1 Restore

Comments

@karol-kokoszka
Copy link
Collaborator

karol-kokoszka commented Jan 13, 2025 •
edited
Loading

First step of the 1-1 restore performed by Scylla Manager is to validate that the destination cluster topology matches the source cluster topology.

Scylla Manager must:

  • validate that all the nodes have an access to the backup location
  • validate that the mapping includes all the nodes
  • validate that the source node belongs to the DC and rack defined by the mapping
  • validate that the destination node belongs to the DC and rack defined by the mapping
  • validate that the destination node has the equal amount of CPUs to the source node amount of CPUs
  • validate that the destination node storage size is GE than the source node storage size
  • validate that the destination node is the owner of the same tokens like the source node

This process must be parallelized per destination node (or source node).
@karol-kokoszka karol-kokoszka added this to the 1-1 Restore milestone Jan 13, 2025
@VAveryanov8 VAveryanov8 self-assigned this Jan 23, 2025
VAveryanov8 added a commit that referenced this issue Jan 27, 2025
@VAveryanov8
feat(1-1-restore): validates if source and target clusters nodes are …
f610c3c 
…equal

This adds a validation stage for 1-1-restore. The logic is as follows:
- Collect node information for the source cluster from backup manifests
- Collect node information for the target cluster from the Scylla API
- Apply node mappings to the source cluster nodes
- Compare each source node with its corresponding target node

Fixes: #4201
@VAveryanov8 VAveryanov8 mentioned this issue Jan 27, 2025
Merged
VAveryanov8 added a commit that referenced this issue Jan 29, 2025
@VAveryanov8
feat(1-1-restore): validates if source and target clusters nodes are …
d102872 
…equal

This adds a validation stage for 1-1-restore. The logic is as follows:
- Collect node information for the source cluster from backup manifests
- Collect node information for the target cluster from the Scylla API
- Apply node mappings to the source cluster nodes
- Compare each source node with its corresponding target node

Fixes: #4201
VAveryanov8 added a commit that referenced this issue Feb 7, 2025
@VAveryanov8
feat(1-1-restore): validates if source and target clusters nodes are …
180b036 
…equal

This adds a validation stage for 1-1-restore. The logic is as follows:
- Collect node information for the source cluster from backup manifests
- Collect node information for the target cluster from the Scylla API
- Apply node mappings to the source cluster nodes
- Compare each source node with its corresponding target node

Fixes: #4201
VAveryanov8 added a commit that referenced this issue Feb 17, 2025
@VAveryanov8
feat(1-1-restore): validates if source and target clusters nodes are …
7a0d4db 
…equal (#4230)

feat(1-1-restore): validates if source and target clusters nodes are equal

This adds a validation stage for 1-1-restore. The logic is as follows:
- Collect node information for the source cluster from backup manifests
- Collect node information for the target cluster from the Scylla API
- Compare each source node with its corresponding target node

Apart from that nodes-mapping param is validated to ensure that each node has exactly one mapping.

Refs: #4201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VAveryanov8 VAveryanov8

Labels
None yet
Projects
None yet
Milestone
1-1 Restore
Development

No branches or pull requests
2 participants
@VAveryanov8 @karol-kokoszka