Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materialized views: View local update description #2403

Closed
vreniers opened this issue Sep 27, 2024 · 6 comments · Fixed by #2417
Closed

Materialized views: View local update description #2403

vreniers opened this issue Sep 27, 2024 · 6 comments · Fixed by #2417
Assignees
Labels
bug Something isn't working right

Comments

@vreniers
Copy link

vreniers commented Sep 27, 2024

Installation details
Panel Name: View Local Update
Dashboard Name: Detailed
Scylla-Monitoring Version: 4.7.2
Scylla-Version: 2024.1.4

While investigating a certain dashboard, I was under the impression that "view local update" actually reflected all updates that are happening on a given replica for that materialized view. Its description mentions for example:

View local update - description: "Number of view update locally"

However, it seems this is not true, and that this is a coordinator-side metric. It does not encompass all updates that are happening locally on that replica with regards to a materialized view.

For example, one could assume that all remote view updates that are being sent out (e.g. 200 remote view updates), would show many local view updates (across other shards, of which the sum could amount to 200) - but that is not what this graph shows. It only seems to show the portion of the updates that remain on the coordinator - and that update a view locally there.

I suggest to perhaps mention or clarify in the description that this is a coordinator-side metric.

@vreniers vreniers added the bug Something isn't working right label Sep 27, 2024
@amnonh
Copy link
Collaborator

amnonh commented Sep 29, 2024

The relevant Scylla code is https://github.com/scylladb/scylladb/blob/c17d353718464bae230331d7e77d4901281fc017/replica/database.cc#L618

I would like someone from MV to have a look and give their input

@amnonh
Copy link
Collaborator

amnonh commented Oct 9, 2024

@mykaul can we have someone from MV comment on the issue?

@mykaul
Copy link
Contributor

mykaul commented Oct 9, 2024

@mykaul can we have someone from MV comment on the issue?

@piodul - please assign.

@amnonh amnonh assigned piodul and unassigned amnonh Oct 10, 2024
@piodul
Copy link

piodul commented Oct 16, 2024

I suggest changing the panels' names and descriptions in the following way:

Local view updates
Counts the number of view updates generated and then applied locally on the same node.

Remote view updates
Counts the number of view updates generated and then sent to be applied on a remote replica.

@vreniers does this sound good?

@vreniers
Copy link
Author

vreniers commented Oct 16, 2024

Local view updates
Counts the number of view updates generated locally and applied on the same node.

A small change perhaps to "local view updates" description. What do you think @piodul? Otherwise, looks good.

@piodul
Copy link

piodul commented Oct 16, 2024

What do you think @piodul? Otherwise, looks good.

@vreniers looks good to me after your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants