-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task manager: task id is reported as not found when the task id is available in system.tablets table #21975
Labels
backport/none
Backport is not required
Comments
asias
changed the title
task manger: task id is reported as not found when the task id is available in system.tablets table
task manager: task id is reported as not found when the task id is available in system.tablets table
Dec 19, 2024
The reproducer can be found here: [email protected]:asias/scylla.git reproducer_for_21975
|
Deexie
added a commit
to Deexie/scylla
that referenced
this issue
Dec 19, 2024
Currently, when the tablet repair is started, info regarding the operation is kept in the system.tablets. The new tablet states are reflected in memory after load_topology_state is called. Before that, the data in the table and the memory aren't consistent. To check the supported operations, tablet_virtual_task uses in-memory tablet_metadata. Hence, it may not see the operation, even though its info is already kept in system.tablets table. Run read barrier in tablet_virtual_task::contains to ensure it will see the latest data. Add a test to check it. Fixes: scylladb#21975.
Deexie
added a commit
to Deexie/scylla
that referenced
this issue
Dec 20, 2024
Currently, when the tablet repair is started, info regarding the operation is kept in the system.tablets. The new tablet states are reflected in memory after load_topology_state is called. Before that, the data in the table and the memory aren't consistent. To check the supported operations, tablet_virtual_task uses in-memory tablet_metadata. Hence, it may not see the operation, even though its info is already kept in system.tablets table. Run read barrier in tablet_virtual_task::contains to ensure it will see the latest data. Add a test to check it. Fixes: scylladb#21975.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Can be reproduced with the test code in PR: #21973.
Remove the get_task_status loop below and abort as soon as the tablet_task_id is obtained.
The text was updated successfully, but these errors were encountered: