Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should mark public symbols with [[gnu::visibility("default")]] #2457

Open
tchaikov opened this issue Sep 27, 2024 · 0 comments
Open

should mark public symbols with [[gnu::visibility("default")]] #2457

tchaikov opened this issue Sep 27, 2024 · 0 comments
Labels

Comments

@tchaikov
Copy link
Contributor

tchaikov commented Sep 27, 2024

currently, we don't differentiate the public symbols from the private ones using [[gnu::visibility("default")]]. but would be desirable if we can have a smaller global / public symbol list exposed from seastar libraries for better performance and for smaller disk foot print, and this can potentially allow the compiler emit more efficient code at the link time.

while symbol visibility is theoretically important for shared libraries (DSO), in practice, it's less critical for seastar applications. many of these applications link against the static build of seastar libraries, and only optionally link to the shared libraries in debug builds. therefore, addressing this issue is not a high priority from a practical standpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant