treewide: include fmt/ostream.h for using fmt::print() #2594
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
explicitly include fmt/ostream.h for fmt::print() The `fmt::print(std::ostream&, ...)` API is provided through `fmt/ostream.h`. Previously, we relied on indirect inclusion of this header through other fmt headers, which was fragile and broke with fmt 8.x. Fix this by explicitly including `fmt/ostream.h` in all source files that use the ostream API. This addresses build failures with fmt 8.x while making the header dependencies more explicit. See https://fmt.dev/11.0/api/#ostream-api Fixes scylladb#2584 Signed-off-by: Kefu Chai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicitly include fmt/ostream.h for fmt::print()
The
fmt::print(std::ostream&, ...)API is provided throughfmt/ostream.h. Previously, we relied on indirect inclusion of this header through other fmt headers, which was fragile and broke with fmt 8.x.Fix this by explicitly including
fmt/ostream.hin all source files that use the ostream API. This addresses build failures with fmt 8.x while making the header dependencies more explicit.See https://fmt.dev/11.0/api/#ostream-api
Fixes #2584