Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve health check and fault-tolerance mechanism #19

Open
a-marcel opened this issue Feb 4, 2017 · 2 comments
Open

Improve health check and fault-tolerance mechanism #19

a-marcel opened this issue Feb 4, 2017 · 2 comments

Comments

@a-marcel
Copy link

a-marcel commented Feb 4, 2017

Hi,

you're using the CircuitBreaker for the proxy services and the health check. In general it's a good idea, but the implementation is a little bit useless.

an example:

ApiGateway
ProductMicroservice
AuthMicroservice

The Microservices are independent from each other.

Case: the ProductMicroservice is not answering in the health Check for 5 times. After that, the ApiGateway CB will stop.

BUT: if one auth request is comming and pass the CB, the complete Gateway is working again.

From my point of view. Every Service should have an independed CB. otherwise the implementation makes no sence in a microservice world. One service should not shutdown the whole system.

Do you've any ideas how to implements this ?

Thanks
Marcel

@sczyh30
Copy link
Owner

sczyh30 commented Feb 9, 2017

Yes, I agree with you. Every service components should have an independent circuit breaker so that the failure of one service does not affect the entire system. As for implementation, I'd like to implement some wrapper functions for circuit breaker in base verticle, then call the wrap functions in each service instance. I'll try to enhance it these days (still thinking the design :-)

Regarding the health check function, that is only a trivial example. I think the service discovery component should be responsible for health check.

Any more advice about the design and implementation?

@a-marcel
Copy link
Author

a-marcel commented Feb 9, 2017

Currently, it sounds good. I'll check the implementation after it. The health check in general is good enough and everybody can adjust the check times and functionality by his own.

@sczyh30 sczyh30 changed the title ApiGateway HealthCheck not very usefull Improve health check and fault-tolerance mechanism Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants