Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shinymeta for code exports #288

Open
4 tasks
GregorDeCillia opened this issue Oct 31, 2019 · 1 comment
Open
4 tasks

use shinymeta for code exports #288

GregorDeCillia opened this issue Oct 31, 2019 · 1 comment
Assignees

Comments

@GregorDeCillia
Copy link
Collaborator

GregorDeCillia commented Oct 31, 2019

I recently took a closer look at the shinymeta package and it seems all code exports that are available in sdcMicro can be produced with that package. However, I think this should be done alongside a rigorous refatoring.

Possible steps

  • migrate all app-related code to R/ to implement the app and all of its components as (internal) functions.
  • Use techniques similar to golem::add_css_file() in order to include the contents of inst/shiny/sdcApp/www/
  • Use metaReactive() for code export
  • Create parametrized Rmd Reports in inst for the "Anonymization Report" and the Landing page of the app

I could also try to only add the code export via shinymeta and leave the other points open for another day. What are your thoughts on this @bernhard-da ?

Schedule

I would wait with the actual code-export refactoring until shinymeta becomes more stable.
However, the other points on this list could be implemented sooner.

@bernhard-da
Copy link
Collaborator

@GregorDeCillia sound interesting and please, have a go. but i think this is (very) low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants