From 20476e02310c2f855a1a157908e66dc8a58518a6 Mon Sep 17 00:00:00 2001
From: Stephen Early <steve@assorted.org.uk>
Date: Thu, 18 Jan 2024 13:37:47 +0000
Subject: [PATCH] Add page showing all transactions in a datatable

Remove the "Deferred transactions" page because it is now redundant.
---
 quicktill/tillweb/datatable.py                | 21 +++--
 .../tillweb/templates/tillweb/index.html      |  2 +-
 .../tillweb/templates/tillweb/tillweb.html    | 12 ++-
 .../tillweb/transactions-deferred.html        | 36 --------
 .../templates/tillweb/transactions.html       | 85 +++++++++++++++++++
 quicktill/tillweb/urls.py                     |  3 +-
 quicktill/tillweb/views.py                    | 15 +---
 7 files changed, 115 insertions(+), 59 deletions(-)
 delete mode 100644 quicktill/tillweb/templates/tillweb/transactions-deferred.html
 create mode 100644 quicktill/tillweb/templates/tillweb/transactions.html

diff --git a/quicktill/tillweb/datatable.py b/quicktill/tillweb/datatable.py
index 9db28848..595be099 100644
--- a/quicktill/tillweb/datatable.py
+++ b/quicktill/tillweb/datatable.py
@@ -128,6 +128,7 @@ def transactions(request, info):
     columns = {
         'id': Transaction.id,
         'sessionid': Transaction.sessionid,
+        'session_date': Session.date,
         'total': Transaction.total,
         'discount_total': Transaction.discount_total,
         'notes': Transaction.notes,
@@ -144,11 +145,16 @@ def transactions(request, info):
                  undefer('discount_total'),
                  contains_eager(Transaction.session))
 
+    # Searching by amount is slow across the entire table. Disable
+    # this if we are not filtering the table first.
+    enable_amount_search = False
+
     # Apply filters from parameters. The 'unfiltered' item count for
     # this table is after this filtering step.
     try:
         sessionid = int(request.GET.get('sessionid'))
         q = q.filter(Session.id == sessionid)
+        enable_amount_search = True
     except (ValueError, TypeError):
         pass
 
@@ -157,11 +163,12 @@ def transactions(request, info):
     fq = q
     state = request.GET.get('state', 'any')
     if state == "closed":
-        q = q.filter(Transaction.closed == True)
+        fq = fq.filter(Transaction.closed == True)
     elif state == "open":
-        q = q.filter(Transaction.closed == False)
+        fq = fq.filter(Transaction.closed == False)\
+               .filter(Transaction.sessionid != None)
     elif state == "deferred":
-        q = q.filter(Transaction.sessionid == None)
+        fq = fq.filter(Transaction.sessionid == None)
     if search_value:
         try:
             intsearch = int(search_value)
@@ -177,7 +184,7 @@ def transactions(request, info):
         if intsearch:
             qs.append(columns['id'] == intsearch)
             qs.append(columns['sessionid'] == intsearch)
-        if decsearch is not None:
+        if enable_amount_search and decsearch is not None:
             qs.append(columns['total'] == decsearch)
             qs.append(columns['discount_total'] == decsearch)
         fq = q.filter(or_(*qs))
@@ -186,9 +193,9 @@ def transactions(request, info):
         request, q, fq, columns, lambda t: {
             'id': t.id,
             'url': t.get_absolute_url(),
-            'sessionid': t.session.id,
-            'session_url': t.session.get_absolute_url(),
-            'session_date': t.session.date,
+            'sessionid': t.session.id if t.session else None,
+            'session_url': t.session.get_absolute_url() if t.session else None,
+            'session_date': t.session.date if t.session else None,
             'total': t.total,
             'discount_total': t.discount_total,
             'notes': t.notes,
diff --git a/quicktill/tillweb/templates/tillweb/index.html b/quicktill/tillweb/templates/tillweb/index.html
index 1308e80f..44e3ee4c 100644
--- a/quicktill/tillweb/templates/tillweb/index.html
+++ b/quicktill/tillweb/templates/tillweb/index.html
@@ -16,7 +16,7 @@
 {% endfor %}{% if currentsession.pending_total %}({{money}}{{currentsession.pending_total}} unpaid){% endif %}</a>
 {% else %}No current session{% endif %}
 {% if deferred %}
-<br><a href="{% url "tillweb-deferred-transactions" pubname=pubname %}">{{money}}{{deferred}} deferred transactions</a>
+<br><a href="{% url "tillweb-transactions" pubname=pubname %}?state=deferred">{{money}}{{deferred}} deferred transactions</a>
 {% endif %}
     </div>
   </div>
diff --git a/quicktill/tillweb/templates/tillweb/tillweb.html b/quicktill/tillweb/templates/tillweb/tillweb.html
index e33935bd..a74e6426 100644
--- a/quicktill/tillweb/templates/tillweb/tillweb.html
+++ b/quicktill/tillweb/templates/tillweb/tillweb.html
@@ -79,7 +79,10 @@
 	  if (data) {
 	      return "Closed";
 	  }
-	  return "Open";
+	  if (row["sessionid"]) {
+	      return "Open";
+	  }
+	  return "Deferred";
       };
   };
 </script>
@@ -115,7 +118,12 @@
 	<div class="collapse navbar-collapse" id="tillwebNavbar">
 	  <ul class="navbar-nav flex-column w-100 justify-content-between">
 	    <li class="nav-item"><a class="nav-link" href="{% url "tillweb-pubroot" pubname=pubname %}">Main Menu</a></li>
-	    <li class="nav-item"><a class="nav-link "href="{% url "tillweb-sessions" pubname=pubname %}">Sessions</a></li>
+	    <li class="nav-item dropdown"><a class="nav-link dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">Register</a>
+	      <div class="dropdown-menu">
+		<a class="dropdown-item" href="{% url "tillweb-sessions" pubname=pubname %}">Sessions</a>
+		<a class="dropdown-item" href="{% url "tillweb-transactions" pubname=pubname %}">Transactions</a>
+	      </div>
+	    </li>
 	    <li class="nav-item"><a class="nav-link" href="{% url "tillweb-departments" pubname=pubname %}">Departments</a></li>
 	    <li class="nav-item dropdown"><a class="nav-link dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">Stock management</a>
 	      <div class="dropdown-menu">
diff --git a/quicktill/tillweb/templates/tillweb/transactions-deferred.html b/quicktill/tillweb/templates/tillweb/transactions-deferred.html
deleted file mode 100644
index f3b099bc..00000000
--- a/quicktill/tillweb/templates/tillweb/transactions-deferred.html
+++ /dev/null
@@ -1,36 +0,0 @@
-{% extends "tillweb/tillweb.html" %}
-
-{% block title %}{{till}} — deferred transactions{% endblock %}
-
-{% block tillcontent %}
-
-{% if transactions %}
-<table class="table table-striped table-hover table-sm w-auto" id="transactions-table">
-<thead class="thead-light">
-  <tr>
-    <th scope="col">Transaction</th>
-    <th scope="col">Amount</th>
-    <th scope="col">Note</th>
-  </tr>
-</thead>
-<tbody>
-{% for t in transactions %}
-<tr>
-<td><a href="{{t.get_absolute_url}}">{{t.id}}</a></td>
-<td class="money">{{money}}{{t.total}}</td>
-<td>{% if t.notes %}{{t.notes}}{% endif %}</td>
-</tr>
-{% endfor %}
-</tbody>
-</table>
-
-<script type="text/javascript">
-$(document).ready(function(){
-  $("#transactions-table").tablesorter();
-});
-</script>
-{% else %}
-<p>There are no deferred transactions at the moment.</p>
-{% endif %}
-
-{% endblock %}
diff --git a/quicktill/tillweb/templates/tillweb/transactions.html b/quicktill/tillweb/templates/tillweb/transactions.html
new file mode 100644
index 00000000..b7c14c6b
--- /dev/null
+++ b/quicktill/tillweb/templates/tillweb/transactions.html
@@ -0,0 +1,85 @@
+{% extends "tillweb/tillweb.html" %}
+
+{% block title %}{{till}} — transactions{% endblock %}
+
+{% block tillcontent %}
+
+<div class="form-group row">
+  <label for="stateSelect" class="col-3 col-form-label">Transaction state</label>
+  <div class="col-9">
+    <select class="form-control" id="stateSelect">
+      <option value="all">Any</option>
+      <option value="closed">Closed</option>
+      <option value="open">Open</option>
+      <option value="deferred">Deferred</option>
+    </select>
+  </div>
+</div>
+
+<table class="table table-sm table-striped" id="transactionsTable">
+  <thead class="thead-light">
+    <tr>
+      <th scope="col">Transaction</th>
+      <th scope="col">Session</th>
+      <th scope="col">Date</th>
+      <th scope="col">Amount</th>
+      <th scope="col">Discount</th>
+      <th scope="col">Note</th>
+      <th scope="col">State</th>
+    </tr>
+  </thead>
+  <tbody></tbody>
+</table>
+
+<script type="text/javascript">
+  $(document).ready(function() {
+      const urlParams = new URLSearchParams(window.location.search);
+      const state = urlParams.get('state') || 'all';
+      $("#stateSelect").val(state);
+      let transaction_state = state;
+      const transactions_table = $("#transactionsTable").DataTable({
+	  ajax: {
+	      url: '{% url "tillweb-datatable-transactions" pubname=pubname %}',
+	      dataSrc: 'data',
+	      data: function (d) {
+		  d.state = transaction_state;
+	      },
+	  },
+	  columns: [
+	      { data: 'id',
+		render: render_link('url', DataTable.render.text()),
+	      },
+	      { data: 'sessionid',
+		render: render_link('session_url', DataTable.render.text()),
+	      },
+	      { data: 'session_date',
+		render: DataTable.render.date(),
+		searchable: false,
+	      },
+	      { data: 'total',
+		render: render_money(),
+	      },
+	      { data: 'discount_total',
+		render: render_money(),
+	      },
+	      { data: 'notes',
+		render: DataTable.render.text(),
+	      },
+	      { data: 'closed',
+		render: render_closed(),
+		searchable: false,
+	      },
+	  ],
+	  order: [ [0, 'desc'] ],
+	  searching: true,
+	  paging: true,
+	  serverSide: true,
+      });
+      $("#stateSelect").change(function() {
+	  transaction_state = this.value;
+	  transactions_table.ajax.reload(null, true);
+      });
+  });
+</script>
+
+{% endblock %}
diff --git a/quicktill/tillweb/urls.py b/quicktill/tillweb/urls.py
index 452c485c..b735bece 100644
--- a/quicktill/tillweb/urls.py
+++ b/quicktill/tillweb/urls.py
@@ -19,8 +19,7 @@
              name="tillweb-session-department"),
     ])),
 
-    path('transaction/deferred/', views.transactions_deferred,
-         name="tillweb-deferred-transactions"),
+    path('transaction/', views.transactions, name="tillweb-transactions"),
     path('transaction/<int:transid>/', views.transaction,
          name="tillweb-transaction"),
 
diff --git a/quicktill/tillweb/views.py b/quicktill/tillweb/views.py
index 4ca304b9..ff22b13e 100644
--- a/quicktill/tillweb/views.py
+++ b/quicktill/tillweb/views.py
@@ -738,17 +738,10 @@ def sessiondept(request, info, sessionid, dept):
 
 
 @tillweb_view
-def transactions_deferred(request, info):
-    """Page showing all deferred transactions"""
-    t = td.s.query(Transaction)\
-            .options(undefer('total'))\
-            .filter(Transaction.sessionid == None)\
-            .order_by(Transaction.id)\
-            .all()
-    return ('transactions-deferred.html', {
-        'transactions': t,
-        'nav': [("Deferred transactions",
-                 info.reverse('tillweb-deferred-transactions'))],
+def transactions(request, info):
+    return ('transactions.html', {
+        'nav': [("Transactions",
+                 info.reverse('tillweb-transactions'))],
     })