Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocorrections #524

Open
bogdan opened this issue Sep 30, 2024 · 3 comments
Open

Add autocorrections #524

bogdan opened this issue Sep 30, 2024 · 3 comments

Comments

@bogdan
Copy link

bogdan commented Sep 30, 2024

Most of haml-lint concerns are too minor to be fixed manually, especially if applied to existing code base.
Please introduces the autocorrect at least for the following easy to fix rules:

  • SpaceInsideHashAttributes
  • ConsecutiveSilentScripts
  • TrailingEmptyLines
  • TrailingWhitespace
  • LeadingCommentSpace
@MaxLap
Copy link
Contributor

MaxLap commented Sep 30, 2024

That's a pretty strong case of "do (more) work for me for free". Maybe it's a barrier of language thing, but that phrasing really feels like it.

@bogdan
Copy link
Author

bogdan commented Sep 30, 2024

Sorry, I didn't mean to offend you. This is how people sometimes frame their requests in my open source repos and I mostly agree because I enjoy helping people by doing things I enjoy to do.
I think "I do more work for you for free" is a principle many open source authors follow. At least I do and met many others who do.

@MaxLap
Copy link
Contributor

MaxLap commented Oct 1, 2024

I'm not offended, I found it a bit funny. Asking for features can be fine. The way of asking can change the tone dramatically.

"please do X" is a polite tone that a boss uses to essentially give an order to an employee.

"at least for" makes it sound like that's the least the person could do. Like it would be unreasonable not to.

Again, maybe just a barrier of language thing. It's not my repo, i just saw the ticket and felt I had to push back a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants