Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsolete iausofa library #9

Open
rmathar opened this issue Sep 16, 2021 · 2 comments
Open

obsolete iausofa library #9

rmathar opened this issue Sep 16, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@rmathar
Copy link

rmathar commented Sep 16, 2021

The directory
https://github.com/sdss/coordio/tree/master/cextern/sofa
is an obsolete version of
https://github.com/liberfa/erfa/tree/master/src

I propse to use the "git subtree" command to replace the obsolete local version and to ensure that the other version (which is known to be maintained actively) is always in use.

Besides: one could get the RPM or Debian packages from
https://build.opensuse.org/package/show/home:rjmathar/iausofa-c
with the zypper or apt command to avoid compiling anything within this module.

@rmathar rmathar added the enhancement New feature or request label Sep 16, 2021
@albireox
Copy link
Member

Hi @rmathar,

Do you know what are the improvements of the newer versions of SOFA? In principle I don't mind updating it, but I since we only use a few features I feel that doing that manually may be better. I've found that adding subtree or modules ends ad making managing the repository more complicated, and people that clone from source not always follow the instructions to initialise the submodule.

Similarly, I would prefer not to depend on an RPM or external installation because that would make coordIO not easily work on macOS, unless you know of an easy way to install SOFA on Mac. Since SOFA is a very simple pure C library compiling it doesn't seem to be likely to cause errors (assuming one has a basic compiler).

@rmathar
Copy link
Author

rmathar commented Nov 3, 2021

i) The changes within the IAU SOFA releases are documented in
https://www.iausofa.org/archive.html
ii) To keep the software up-to-date with the upstream release has nothing to do with "RPM" or "external installation" or Macs. The RPM's mean that people can get up-to-date versions of the software by bypassing the obsolete variant maintained here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants