Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test numpy > 2 and resolve any issues #116

Open
havok2063 opened this issue Jun 21, 2024 · 0 comments
Open

Test numpy > 2 and resolve any issues #116

havok2063 opened this issue Jun 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@havok2063
Copy link
Collaborator

havok2063 commented Jun 21, 2024

We should test the DRP with numpy > 2.0. numpy > 2 introduced some breaking changes, and changes in algorithms, which may result in numerical differences. Additionally, not all packages have added support yet for numpy > 2.

To resolve some package dependencies, you need

  • numpy > 2.0
  • pandas > 2.2.2
  • astropy > 6.3
  • bottleneck > 1.4
  • numexpr > 2.10

When testing, I see some failures between pandas and numpy, with the error ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject. Even though pandas == 2.2.2 is installed, there may still be some incompatibilities with either pandas, h5py, or some internal c-code. See, e.g. numpy/numpy#26710 or https://stackoverflow.com/questions/78634235/numpy-dtype-size-changed-may-indicate-binary-incompatibility-expected-96-from

numpy pinned to < 2 in #115. Also see https://numpy.org/doc/2.0/numpy_2_0_migration_guide.html and https://numpy.org/doc/2.0/release/2.0.0-notes.html

@havok2063 havok2063 added the enhancement New feature or request label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant