Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drpqual not populated properly in Sframe and hence not in drp_all.fits #124

Open
kslong opened this issue Jul 27, 2024 · 3 comments
Open

Comments

@kslong
Copy link
Contributor

kslong commented Jul 27, 2024

In version 1.0.3, the drpall-1.0.3.fits file has a keyword drpqual, which I assume should indicate whether the drp processes the exposure properly, but all of the values in this column are 0, including exposures for which there was no flux calibration. If this keyword is supposed to catch problems, then this looks like an error. If this keyword is not intended to catch this, then there ought to be a keyword that does.

@havok2063
Copy link
Collaborator

havok2063 commented Jul 29, 2024

This is not a drpall file problem. The drpall file pulls the DRPQUAL value from the headers of the lvmSFrame files. We currently are not tracking any pipeline quality issues during the reductions, and are not updating this value. That's why it is always 0, which is the default value we start at. The pipeline has no quality assessment tracking implemented at the moment.

@kslong kslong changed the title drpqual not populated properly in drp_all.fits drpqual not populated properly in Sframe and hence not in drp_all.fits Jul 29, 2024
@kslong
Copy link
Contributor Author

kslong commented Jul 29, 2024

Agreed. I have changed the name. The real issue is that the DRPQUAL value is not populated in the DRP

@ajmejia
Copy link
Contributor

ajmejia commented Aug 1, 2024

This issue (the lack of quality flags for different reduction steps) is in the list we've been discussing the last weeks. I'll address this when it moves up in the list of priorities. I don't think this will be a stopper to make progress on other opened issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants