{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":167521394,"defaultBranch":"master","name":"addressbook-level3","ownerLogin":"se-edu","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-01-25T09:28:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/20763652?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718256801.0","currentOid":""},"activityList":{"items":[{"before":"6c19411c74b798a9c147fe8b58cdcdd47271acd1","after":"d925b35c5232000742c362985bf078815cf6f026","ref":"refs/heads/master","pushedAt":"2024-06-13T05:52:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Fix double-space between index and name\n\nThe spacing attribute for HBox in PersonListCard.fxml is set to '5',\r\ncausing it to look like a double-space is present in the Person\r\nList Card (e.g. 1.  John)\r\n\r\nLet's reduce the spacing attribute of the HBox in\r\nPersonListCard.fxml (which determines the spacing between child\r\nelements) to 0.5, which seems to produce the desired gap, so that\r\nit looks like a single space is present instead of double\r\n(e.g. 1. John).","shortMessageHtmlLink":"Fix double-space between index and name"}},{"before":"880d3728968e4685dda8b9e8bf7141c7e5646afe","after":null,"ref":"refs/heads/dependabot/bundler/docs/rexml-3.2.8","pushedAt":"2024-06-13T05:33:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"bb3a17377b5140d79d9817eccb1423e3684a8e58","after":"6c19411c74b798a9c147fe8b58cdcdd47271acd1","ref":"refs/heads/master","pushedAt":"2024-06-13T05:33:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Bump rexml from 3.2.5 to 3.2.8 in /docs\n\nBumps [rexml](https://github.com/ruby/rexml) from 3.2.5 to 3.2.8.\n- [Release notes](https://github.com/ruby/rexml/releases)\n- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)\n- [Commits](https://github.com/ruby/rexml/compare/v3.2.5...v3.2.8)\n\n---\nupdated-dependencies:\n- dependency-name: rexml\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump rexml from 3.2.5 to 3.2.8 in /docs"}},{"before":"ce29e286745f617e8cb3976dfa2631e501a53dd5","after":null,"ref":"refs/heads/dependabot/bundler/docs/nokogiri-1.16.5","pushedAt":"2024-06-13T05:32:26.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"b896eb01c1e50e6acdf7f9636ca7d5785729c954","after":"bb3a17377b5140d79d9817eccb1423e3684a8e58","ref":"refs/heads/master","pushedAt":"2024-06-13T05:32:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Bump nokogiri from 1.16.2 to 1.16.5 in /docs\n\nBumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.2 to 1.16.5.\n- [Release notes](https://github.com/sparklemotion/nokogiri/releases)\n- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)\n- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.16.2...v1.16.5)\n\n---\nupdated-dependencies:\n- dependency-name: nokogiri\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump nokogiri from 1.16.2 to 1.16.5 in /docs"}},{"before":null,"after":"880d3728968e4685dda8b9e8bf7141c7e5646afe","ref":"refs/heads/dependabot/bundler/docs/rexml-3.2.8","pushedAt":"2024-05-16T20:46:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump rexml from 3.2.5 to 3.2.8 in /docs\n\nBumps [rexml](https://github.com/ruby/rexml) from 3.2.5 to 3.2.8.\n- [Release notes](https://github.com/ruby/rexml/releases)\n- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)\n- [Commits](https://github.com/ruby/rexml/compare/v3.2.5...v3.2.8)\n\n---\nupdated-dependencies:\n- dependency-name: rexml\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump rexml from 3.2.5 to 3.2.8 in /docs"}},{"before":null,"after":"ce29e286745f617e8cb3976dfa2631e501a53dd5","ref":"refs/heads/dependabot/bundler/docs/nokogiri-1.16.5","pushedAt":"2024-05-13T23:39:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump nokogiri from 1.16.2 to 1.16.5 in /docs\n\nBumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.2 to 1.16.5.\n- [Release notes](https://github.com/sparklemotion/nokogiri/releases)\n- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)\n- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.16.2...v1.16.5)\n\n---\nupdated-dependencies:\n- dependency-name: nokogiri\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump nokogiri from 1.16.2 to 1.16.5 in /docs"}},{"before":"da647a31d3f265287dbaf3cac6adc8a7272be68c","after":"8d18d37017ac5b670b8eca7691af95087ab138e0","ref":"refs/heads/switch-docs-to-markbind","pushedAt":"2024-02-09T10:12:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Reduce font size for printing","shortMessageHtmlLink":"Reduce font size for printing"}},{"before":"b68489d2f532f4bfeba0e552f63ccc76a9d44e6d","after":"b896eb01c1e50e6acdf7f9636ca7d5785729c954","ref":"refs/heads/master","pushedAt":"2024-02-09T10:11:16.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Merge branch 'master' of https://github.com/se-edu/addressbook-level3","shortMessageHtmlLink":"Merge branch 'master' of <a href=\"https://github.com/se-edu/addressbook-level3\">https://github.com/se-edu/addressbook-level3</a>"}},{"before":"e8bd09ed91d74307bb21accd74c5df8047f645a7","after":null,"ref":"refs/heads/dependabot/bundler/docs/nokogiri-1.16.2","pushedAt":"2024-02-09T08:56:18.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"517b78574b054b30f8e02c9f511c12a916fb64b8","after":"b68489d2f532f4bfeba0e552f63ccc76a9d44e6d","ref":"refs/heads/master","pushedAt":"2024-02-09T08:56:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Bump nokogiri from 1.15.2 to 1.16.2 in /docs\n\nBumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.15.2 to 1.16.2.\n- [Release notes](https://github.com/sparklemotion/nokogiri/releases)\n- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)\n- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.15.2...v1.16.2)\n\n---\nupdated-dependencies:\n- dependency-name: nokogiri\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump nokogiri from 1.15.2 to 1.16.2 in /docs"}},{"before":null,"after":"e8bd09ed91d74307bb21accd74c5df8047f645a7","ref":"refs/heads/dependabot/bundler/docs/nokogiri-1.16.2","pushedAt":"2024-02-06T03:35:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump nokogiri from 1.15.2 to 1.16.2 in /docs\n\nBumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.15.2 to 1.16.2.\n- [Release notes](https://github.com/sparklemotion/nokogiri/releases)\n- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)\n- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.15.2...v1.16.2)\n\n---\nupdated-dependencies:\n- dependency-name: nokogiri\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump nokogiri from 1.15.2 to 1.16.2 in /docs"}},{"before":"d39eadb589e669026981b69b662ea6f3319da432","after":"da647a31d3f265287dbaf3cac6adc8a7272be68c","ref":"refs/heads/switch-docs-to-markbind","pushedAt":"2023-09-11T17:22:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Migrate docs to MarkBind\n\nLet's migrate the docs site from Jekyll to MarkBind.\n\nPrimary author: @tlylt in se-edu/addressbook-level3/pull/156\nFurther tweaks: @damithc in se-edu/addressbook-level3/pull/206","shortMessageHtmlLink":"Migrate docs to MarkBind"}},{"before":"07778d9f6d10d711d130e5713e7463d03027146d","after":"517b78574b054b30f8e02c9f511c12a916fb64b8","ref":"refs/heads/master","pushedAt":"2023-09-11T16:49:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Add puml files for tutorial class diagrams\n\nTwo class diagrams in 'Add Remark Command' tutorial don't\nhave corresponding .puml files. Furthermore, the diagrams\nhave some errors.\n\nLet's correct the errors, and also add the missing .puml files.\n\nAlso, let's rename the files to more suitable names.","shortMessageHtmlLink":"Add puml files for tutorial class diagrams"}},{"before":null,"after":"d39eadb589e669026981b69b662ea6f3319da432","ref":"refs/heads/switch-docs-to-markbind","pushedAt":"2023-09-11T15:06:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Tweak the content further\n\n* Remove unused images\n* Replace frontmatter with ---\n* Change box style light -> seamless\n* Tweak the Documentation.md\n* Tweak other content for nits\n* Ignore logs\n* Add missing puml files","shortMessageHtmlLink":"Tweak the content further"}},{"before":"7cd044b7d7cb63e58b533d8ea8ba414f9414ad3d","after":"07778d9f6d10d711d130e5713e7463d03027146d","ref":"refs/heads/master","pushedAt":"2023-09-09T09:03:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Limit Codecov upload to Linux only","shortMessageHtmlLink":"Limit Codecov upload to Linux only"}},{"before":"eb0af9cce7b2048770055d986460fa6b4644f89d","after":"7cd044b7d7cb63e58b533d8ea8ba414f9414ad3d","ref":"refs/heads/master","pushedAt":"2023-09-09T08:58:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Update gradle.yml to use Codecov action@v3","shortMessageHtmlLink":"Update gradle.yml to use Codecov action@v3"}},{"before":"afed94052e14e2429d1de0c330fb4ae0980912f1","after":"eb0af9cce7b2048770055d986460fa6b4644f89d","ref":"refs/heads/master","pushedAt":"2023-09-08T05:05:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"UG: Add a 'Known issues' section","shortMessageHtmlLink":"UG: Add a 'Known issues' section"}},{"before":"3203996630e007452086f71ee2cefb652b0a30b3","after":"afed94052e14e2429d1de0c330fb4ae0980912f1","ref":"refs/heads/master","pushedAt":"2023-09-03T13:33:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Tweak the DG's design details for readability","shortMessageHtmlLink":"Tweak the DG's design details for readability"}},{"before":"f5f6a34478335caf0f466962683304cc34de4f35","after":null,"ref":"refs/heads/dependabot/bundler/docs/activesupport-7.0.7.2","pushedAt":"2023-09-03T12:09:12.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"dc554766f367663e7e23bcfe6bf4909f0d6c30e8","after":"3203996630e007452086f71ee2cefb652b0a30b3","ref":"refs/heads/master","pushedAt":"2023-09-03T12:09:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Bump activesupport from 7.0.5 to 7.0.7.2 in /docs\n\nBumps [activesupport](https://github.com/rails/rails) from 7.0.5 to 7.0.7.2.\n- [Release notes](https://github.com/rails/rails/releases)\n- [Changelog](https://github.com/rails/rails/blob/v7.0.7.2/activesupport/CHANGELOG.md)\n- [Commits](https://github.com/rails/rails/compare/v7.0.5...v7.0.7.2)\n\n---\nupdated-dependencies:\n- dependency-name: activesupport\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump activesupport from 7.0.5 to 7.0.7.2 in /docs"}},{"before":"043eeb566e168fac34d88e38c8b2305ae1b3a2ea","after":"f5f6a34478335caf0f466962683304cc34de4f35","ref":"refs/heads/dependabot/bundler/docs/activesupport-7.0.7.2","pushedAt":"2023-09-03T12:02:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump activesupport from 7.0.5 to 7.0.7.2 in /docs\n\nBumps [activesupport](https://github.com/rails/rails) from 7.0.5 to 7.0.7.2.\n- [Release notes](https://github.com/rails/rails/releases)\n- [Changelog](https://github.com/rails/rails/blob/v7.0.7.2/activesupport/CHANGELOG.md)\n- [Commits](https://github.com/rails/rails/compare/v7.0.5...v7.0.7.2)\n\n---\nupdated-dependencies:\n- dependency-name: activesupport\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump activesupport from 7.0.5 to 7.0.7.2 in /docs"}},{"before":"04e25f162281c579c274095d46212580cf021f92","after":"dc554766f367663e7e23bcfe6bf4909f0d6c30e8","ref":"refs/heads/master","pushedAt":"2023-09-03T11:54:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Adjust log initialization position in MainApp\n\nIn the MainApp class, let's move the call to the initLogging method\ncloser to the start of the execution start point, to minimize the\npossibility of log statements being executed before the desired log\nlevel is set.","shortMessageHtmlLink":"Adjust log initialization position in MainApp"}},{"before":null,"after":"043eeb566e168fac34d88e38c8b2305ae1b3a2ea","ref":"refs/heads/dependabot/bundler/docs/activesupport-7.0.7.2","pushedAt":"2023-08-23T21:46:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump activesupport from 7.0.5 to 7.0.7.2 in /docs\n\nBumps [activesupport](https://github.com/rails/rails) from 7.0.5 to 7.0.7.2.\n- [Release notes](https://github.com/rails/rails/releases)\n- [Changelog](https://github.com/rails/rails/blob/v7.0.7.2/activesupport/CHANGELOG.md)\n- [Commits](https://github.com/rails/rails/compare/v7.0.5...v7.0.7.2)\n\n---\nupdated-dependencies:\n- dependency-name: activesupport\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump activesupport from 7.0.5 to 7.0.7.2 in /docs"}},{"before":"08fe6e3fc795e8f21e340b25e0fb57b4d00d3d6b","after":"04e25f162281c579c274095d46212580cf021f92","ref":"refs/heads/master","pushedAt":"2023-08-21T09:10:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Update version to v0.2.2ea","shortMessageHtmlLink":"Update version to v0.2.2ea"}},{"before":"85a6207f505e9a09532f09918b74d06fcefa3cf6","after":null,"ref":"refs/heads/dependabot/bundler/docs/commonmarker-0.23.10","pushedAt":"2023-08-09T04:16:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"83b10b01b64edc96e16978bb65812379e545020f","after":"08fe6e3fc795e8f21e340b25e0fb57b4d00d3d6b","ref":"refs/heads/master","pushedAt":"2023-08-09T04:15:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Bump commonmarker from 0.23.9 to 0.23.10 in /docs\n\nBumps [commonmarker](https://github.com/gjtorikian/commonmarker) from 0.23.9 to 0.23.10.\n- [Release notes](https://github.com/gjtorikian/commonmarker/releases)\n- [Changelog](https://github.com/gjtorikian/commonmarker/blob/v0.23.10/CHANGELOG.md)\n- [Commits](https://github.com/gjtorikian/commonmarker/compare/v0.23.9...v0.23.10)\n\n---\nupdated-dependencies:\n- dependency-name: commonmarker\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump commonmarker from 0.23.9 to 0.23.10 in /docs"}},{"before":null,"after":"85a6207f505e9a09532f09918b74d06fcefa3cf6","ref":"refs/heads/dependabot/bundler/docs/commonmarker-0.23.10","pushedAt":"2023-08-08T20:26:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump commonmarker from 0.23.9 to 0.23.10 in /docs\n\nBumps [commonmarker](https://github.com/gjtorikian/commonmarker) from 0.23.9 to 0.23.10.\n- [Release notes](https://github.com/gjtorikian/commonmarker/releases)\n- [Changelog](https://github.com/gjtorikian/commonmarker/blob/v0.23.10/CHANGELOG.md)\n- [Commits](https://github.com/gjtorikian/commonmarker/compare/v0.23.9...v0.23.10)\n\n---\nupdated-dependencies:\n- dependency-name: commonmarker\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump commonmarker from 0.23.9 to 0.23.10 in /docs"}},{"before":"e9f1ca7de5d873d6ee273af54f503513c731d41d","after":"83b10b01b64edc96e16978bb65812379e545020f","ref":"refs/heads/master","pushedAt":"2023-08-04T15:06:19.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"Upgrade JavaFX to ver 17\n\nThe application uses JavaFX 11 which is reaching its EOL in September\n2023. Thus it is better to upgrade JavaFX to the next LTS version which\nis version 17.\n\nHowever, after version 16, JavaFX now throws a warning when JavaFX\nmodules are loaded from the classpath. As there is currently no plan to\nmigrate to using Modules in AB3, let's include an additional log message\nto inform the users to ignore the warning message.","shortMessageHtmlLink":"Upgrade JavaFX to ver 17"}},{"before":"38922aa825a2bbedaf922230b5cbd145e378607a","after":"e9f1ca7de5d873d6ee273af54f503513c731d41d","ref":"refs/heads/master","pushedAt":"2023-08-04T14:43:39.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"damithc","name":"Damith C. Rajapakse","path":"/damithc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1673303?s=80&v=4"},"commit":{"message":"PersonCard: remove #equals(object)\n\nThis method implements a very weak notion of equivalence, where as long\nas the PersonCard's person and id are equal, the object is equal.\nHowever, such a weak notion of equivalence goes against the spirit of\nthe UI architecture, which states that all UiParts represent a distinct\npart of the UI, and more importantly, wraps a subgraph of the JavaFX\nscene graph (accessible via UiPart#getRoot()). As such, just because two\nPersonCards A and B happen to contain the same ID and person value,\ndoesn't mean they are \"equal\", because they may be holding different\nJavaFX scene graph objects. Any JavaFX-related operations on PersonCard\nA may give a different result to PersonCard B.\n\nFurthermore, this implementation of PersonCard#equals(Object) isn't\nactually used, not even by test code. It was introduced in baa5988d\n(PersonListPanelHandle: Update methods, 2017-07-14) so that one could\ndo the following to assert that a certain PersonCard was selected:\n\n    private void assertCardSelected(Index index) {\n        PersonCard selectedCard = getPersonListPanel().getSelectedCard().get();\n        assertEquals(getPersonListPanel().getCard(index.getZeroBased()), selectedCard);\n    }\n\nwhere the assertEquals() would then call PersonCard#equals(Object).\n\nHowever, since 04a675ff (PersonListPanelHandle: Update\ngetSelectedCard(), 2017-07-20) this pattern of code has been (rightly)\nremoved, with test code preferring to compare what is actually displayed\non the PersonCard, rather than using PersonCard#equals(Object):\n\n    /**\n     * Asserts that {@code actualCard} displays the same values as {@code expectedCard}.\n     */\n    public static void assertCardEquals(PersonCardHandle expectedCard, PersonCardHandle actualCard) {\n        assertEquals(expectedCard.getId(), actualCard.getId());\n        assertEquals(expectedCard.getAddress(), actualCard.getAddress());\n        assertEquals(expectedCard.getEmail(), actualCard.getEmail());\n        assertEquals(expectedCard.getName(), actualCard.getName());\n        assertEquals(expectedCard.getPhone(), actualCard.getPhone());\n        assertEquals(expectedCard.getTags(), actualCard.getTags());\n    }\n\nPersonCard#equals(Object) was, however, not removed then. So let's\nremove it now.","shortMessageHtmlLink":"PersonCard: remove #equals(object)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEZAccawA","startCursor":null,"endCursor":null}},"title":"Activity · se-edu/addressbook-level3"}