diff --git a/build.gradle b/build.gradle index f76144ce9..a2951cc70 100644 --- a/build.gradle +++ b/build.gradle @@ -42,7 +42,7 @@ task coverage(type: JacocoReport) { dependencies { String jUnitVersion = '5.4.0' - String javaFxVersion = '11.0.2' + String javaFxVersion = '17.0.7' implementation group: 'org.openjfx', name: 'javafx-base', version: javaFxVersion, classifier: 'win' implementation group: 'org.openjfx', name: 'javafx-base', version: javaFxVersion, classifier: 'mac' diff --git a/src/main/java/seedu/address/Main.java b/src/main/java/seedu/address/Main.java index 052a50686..ec1b79587 100644 --- a/src/main/java/seedu/address/Main.java +++ b/src/main/java/seedu/address/Main.java @@ -1,6 +1,9 @@ package seedu.address; +import java.util.logging.Logger; + import javafx.application.Application; +import seedu.address.commons.core.LogsCenter; /** * The main entry point to the application. @@ -19,7 +22,20 @@ * to be the entry point of the application, we avoid this issue. */ public class Main { + private static Logger logger = LogsCenter.getLogger(Main.class); + public static void main(String[] args) { + + // As per https://github.com/openjdk/jfx/blob/master/doc-files/release-notes-16.md + // JavaFX 16 (or later) runtime logs a warning at startup if JavaFX classes are loaded from + // the classpath instead of a module. + // Our application does not use Java modules yet. Even if it did, modules are ignored when + // packed into a FAT Jar file (as we do), which means this warning will persist even then. + // The warning however, can be safely ignored. Thus, the following log informs + // the user (if looking at the log output) that the said warning appearing in the log + // can be ignored. + + logger.warning("The warning about Unsupported JavaFX configuration below can be ignored."); Application.launch(MainApp.class, args); } } diff --git a/src/main/resources/view/CommandBox.fxml b/src/main/resources/view/CommandBox.fxml index 09f6d6fe9..124283a39 100644 --- a/src/main/resources/view/CommandBox.fxml +++ b/src/main/resources/view/CommandBox.fxml @@ -3,7 +3,7 @@ - + diff --git a/src/main/resources/view/HelpWindow.fxml b/src/main/resources/view/HelpWindow.fxml index 5dea0adef..e01f330de 100644 --- a/src/main/resources/view/HelpWindow.fxml +++ b/src/main/resources/view/HelpWindow.fxml @@ -9,7 +9,7 @@ - + diff --git a/src/main/resources/view/MainWindow.fxml b/src/main/resources/view/MainWindow.fxml index a431648f6..7778f666a 100644 --- a/src/main/resources/view/MainWindow.fxml +++ b/src/main/resources/view/MainWindow.fxml @@ -11,7 +11,7 @@ - diff --git a/src/main/resources/view/PersonListCard.fxml b/src/main/resources/view/PersonListCard.fxml index f08ea32ad..f5e812e25 100644 --- a/src/main/resources/view/PersonListCard.fxml +++ b/src/main/resources/view/PersonListCard.fxml @@ -9,7 +9,7 @@ - + diff --git a/src/main/resources/view/PersonListPanel.fxml b/src/main/resources/view/PersonListPanel.fxml index 8836d323c..a1bb6bbac 100644 --- a/src/main/resources/view/PersonListPanel.fxml +++ b/src/main/resources/view/PersonListPanel.fxml @@ -3,6 +3,6 @@ - + diff --git a/src/main/resources/view/ResultDisplay.fxml b/src/main/resources/view/ResultDisplay.fxml index 58d5ad3dc..01b691792 100644 --- a/src/main/resources/view/ResultDisplay.fxml +++ b/src/main/resources/view/ResultDisplay.fxml @@ -3,7 +3,7 @@ -