fix: Merge pull request #31 from seamapi/fix-allow-returning-dates

Author: codetheweb

src/index.ts

@@ -30,6 +30,8 @@ const isSerializable = (obj: Record<any, any>): boolean => {
       typeof val === "string" ||
       typeof val === "boolean" ||
       typeof val === "number" ||
+      val?.constructor === Date ||
+      val === null ||
       Array.isArray(val) ||
       isPlainObject(val)
     )

src/tests/hooks.test.ts

@@ -125,25 +125,53 @@ test("beforeTemplateIsBaked (propagates error that isn't serializable)", async (
 })
 
 test("beforeTemplateIsBaked (result isn't serializable)", async (t) => {
-  const getTestServer = getTestPostgresDatabaseFactory({
+  type HookReturn = {
+    type: "function" | "date" | null
+  }
+
+  const getTestServer = getTestPostgresDatabaseFactory<HookReturn>({
     postgresVersion: process.env.POSTGRES_VERSION,
     workerDedupeKey: "beforeTemplateIsBakedHookNonSerializable",
-    beforeTemplateIsBaked: async () => {
+    beforeTemplateIsBaked: async ({ params: { type } }) => {
+      if (type === "function") {
+        return {
+          foo: () => "bar",
+        }
+      }
+
+      if (type === "date") {
+        return {
+          foo: new Date(),
+        }
+      }
+
       return {
-        foo: () => "bar",
+        foo: null,
       }
     },
   })
 
   // Should throw error with clear message
   await t.throwsAsync(
     async () => {
-      await getTestServer(t)
+      await getTestServer(t, { type: "function" })
     },
     {
       message: /could not be serialized/,
     }
   )
+
+  // Can return a date
+  const { beforeTemplateIsBakedResult } = await getTestServer(t, {
+    type: "date",
+  })
+  t.true(beforeTemplateIsBakedResult.foo instanceof Date)
+
+  // Can return null
+  const { beforeTemplateIsBakedResult: result } = await getTestServer(t, {
+    type: null,
+  })
+  t.is(result.foo, null)
 })
 
 test("beforeTemplateIsBaked with manual template build", async (t) => {