-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returning NonZeroUsize
#105
Comments
Changing the return type is a breaking change, and probably low value (see #43 for another example). Documenting seems fine, though! |
Understandable. In any case, #106 is ready. |
I'd probably close. I think that a v2 of num_cpus isn't the end of the world and could be done, but I'd probably hope to see a researched proposal of the changes to make and why for each. |
Glancing over the code I noticed that
get
andget_physical
always returns at least 1, this isn't documented anywhere as far as I looked.My proposition would be returning
NonZeroUsize
instead ofusize
.But I believe at least this should be documented.
The text was updated successfully, but these errors were encountered: