From 4855aa56e8c2a5014e18f74297803f7e6e703ef9 Mon Sep 17 00:00:00 2001
From: Chad Burt <chad@underbluewaters.net>
Date: Fri, 17 Jan 2025 10:50:15 -0800
Subject: [PATCH] Error handling for about page image uploads

---
 packages/api/src/plugins/fileUploadPlugin.ts  |   4 +-
 .../client/src/admin/AboutPageSettings.tsx    |   4 +-
 packages/client/src/editor/EditorMenuBar.tsx  |  16 ++-
 packages/client/src/editor/config.ts          | 122 ++++++++++--------
 4 files changed, 86 insertions(+), 60 deletions(-)

diff --git a/packages/api/src/plugins/fileUploadPlugin.ts b/packages/api/src/plugins/fileUploadPlugin.ts
index 1e7c5654..23bf41f1 100644
--- a/packages/api/src/plugins/fileUploadPlugin.ts
+++ b/packages/api/src/plugins/fileUploadPlugin.ts
@@ -121,7 +121,9 @@ const FileUploadPlugin = makeExtendSchemaPlugin((build) => {
           const isCloudflareImagesSupported =
             cloudflareImagesSupported.includes(contentType) &&
             fileSizeBytes < bytes("10mb");
-          if (isCloudflareImagesSupported) {
+          if (usage === "about_page" && fileSizeBytes >= bytes("10mb")) {
+            throw new Error("File size must be less than 10MB");
+          } else if (isCloudflareImagesSupported) {
             const img = await getDirectCreatorUploadUrl();
 
             const { rows } = await context.adminPool.query(
diff --git a/packages/client/src/admin/AboutPageSettings.tsx b/packages/client/src/admin/AboutPageSettings.tsx
index a19a2474..1e8c2479 100644
--- a/packages/client/src/admin/AboutPageSettings.tsx
+++ b/packages/client/src/admin/AboutPageSettings.tsx
@@ -21,6 +21,7 @@ import "prosemirror-image-plugin/dist/styles/common.css";
 import "./prosemirror-image.css";
 import { useApolloClient } from "@apollo/client";
 import { startImageUpload } from "prosemirror-image-plugin";
+import { useGlobalErrorHandler } from "../components/GlobalErrorHandler";
 
 export default function AboutPageSettings({
   projectId,
@@ -34,9 +35,10 @@ export default function AboutPageSettings({
   });
 
   const client = useApolloClient();
+  const onError = useGlobalErrorHandler();
 
   const { schema, plugins, imageSettings } = useMemo(() => {
-    return createAboutPageEditorConfig(client, projectId);
+    return createAboutPageEditorConfig(client, projectId, onError);
   }, [client, projectId]);
 
   const [mutate, mutationState] = useUpdateAboutPageContentsMutation();
diff --git a/packages/client/src/editor/EditorMenuBar.tsx b/packages/client/src/editor/EditorMenuBar.tsx
index 1a86a744..2f31381c 100644
--- a/packages/client/src/editor/EditorMenuBar.tsx
+++ b/packages/client/src/editor/EditorMenuBar.tsx
@@ -960,6 +960,7 @@ function ImageModal({
 }) {
   const { t } = useTranslation();
   const [saving, setSaving] = useState(false);
+  const [error, setError] = useState<string | null>(null);
   return (
     <Modal onRequestClose={onRequestClose} title={t("Upload Image")}>
       <p className="text-sm text-gray-500">
@@ -990,6 +991,14 @@ function ImageModal({
           type="file"
           name="image"
           accept="image/*"
+          onChange={(e) => {
+            const file = e.target.files?.[0];
+            if (file && file.size >= 10 * 1024 * 1024) {
+              setError("File must be less than 10MB");
+            } else {
+              setError(null);
+            }
+          }}
         />
         <input
           className="block w-128 border-gray-300 rounded-md focus:border-blue-300 focus:ring focus:ring-blue-200 focus:ring-opacity-50 text-black"
@@ -997,10 +1006,13 @@ function ImageModal({
           name="alt-text"
           placeholder="Alt text"
         />
+        {error && <p className="text-red-500 text-sm py-2">{error}</p>}
         <div className="space-x-2 pt-4">
           <button
-            className="border rounded px-2 py-0.5 border-gray-500 bg-gray-200 "
-            disabled={saving}
+            className={`border rounded px-2 py-0.5 border-gray-500 bg-gray-200 ${
+              error || saving ? "opacity-50" : ""
+            }`}
+            disabled={saving || Boolean(error)}
             type="submit"
           >
             {t("Submit")}
diff --git a/packages/client/src/editor/config.ts b/packages/client/src/editor/config.ts
index 11d8535a..82a0b76d 100644
--- a/packages/client/src/editor/config.ts
+++ b/packages/client/src/editor/config.ts
@@ -261,66 +261,76 @@ const aboutPageSchema = new Schema({
 
 export function createAboutPageEditorConfig(
   client: ApolloClient<any>,
-  projectId: number
+  projectId: number,
+  onError: (e: Error) => void
 ) {
   const uploadFile: (file: File) => Promise<string> = async (file) => {
-    const response = await client.mutate({
-      mutation: CreateFileUploadForAboutPageDocument,
-      variables: {
-        contentType: file.type,
-        filename: file.name,
-        fileSizeBytes: file.size,
-        projectId,
-      },
-    });
-    const uploadUrl =
-      response?.data?.createFileUpload?.cloudflareImagesUploadUrl;
-    if (!uploadUrl) {
-      throw new Error("Failed to get upload URL");
-    }
-    const formData = new FormData();
-    formData.append("file", file);
-    const res = await axios({
-      url: uploadUrl,
-      method: "POST",
-      data: formData,
-    });
-    if (
-      "data" in res &&
-      res.data &&
-      "result" in res.data &&
-      res.data["result"] &&
-      "variants" in res.data["result"] &&
-      res.data["result"]["variants"] &&
-      Array.isArray(res.data["result"]["variants"])
-    ) {
-      const variants = res.data["result"]["variants"] as string[];
-      const prosemirrorEmbed = variants.find((variant: any) =>
-        /prosemirrorEmbed/.test(variant)
-      );
-      if (!prosemirrorEmbed) {
-        throw new Error("Could not find prosemirrorEmbed variant");
+    try {
+      const response = await client
+        .mutate({
+          mutation: CreateFileUploadForAboutPageDocument,
+          variables: {
+            contentType: file.type,
+            filename: file.name,
+            fileSizeBytes: file.size,
+            projectId,
+          },
+        })
+        .catch((e) => {
+          throw new Error(`Failed to create file upload. ${e.message}`);
+        });
+      const uploadUrl =
+        response?.data?.createFileUpload?.cloudflareImagesUploadUrl;
+      if (!uploadUrl) {
+        throw new Error("Failed to get upload URL");
       }
-      // This rediculous hack is necessary to avoid having the image
-      // flash with a broken icon (in chrome, others?) for a second
-      // before it finally loads. The image is preloaded in a hidden
-      // position before being finally inserted into the prosemirror
-      // document.
-      return new Promise((resolve) => {
-        const img = document.createElement("img");
-        img.src = prosemirrorEmbed;
-        img.setAttribute(
-          "style",
-          "position: absolute; top: -10000px; left: -10000px;"
-        );
-        img.onload = () => {
-          resolve(prosemirrorEmbed);
-          document.body.removeChild(img);
-        };
-        document.body.append(img);
+      const formData = new FormData();
+      formData.append("file", file);
+      const res = await axios({
+        url: uploadUrl,
+        method: "POST",
+        data: formData,
       });
-    } else {
-      throw new Error("Could not get variants from upload response");
+      if (
+        "data" in res &&
+        res.data &&
+        "result" in res.data &&
+        res.data["result"] &&
+        "variants" in res.data["result"] &&
+        res.data["result"]["variants"] &&
+        Array.isArray(res.data["result"]["variants"])
+      ) {
+        const variants = res.data["result"]["variants"] as string[];
+        const prosemirrorEmbed = variants.find((variant: any) =>
+          /prosemirrorEmbed/.test(variant)
+        );
+        if (!prosemirrorEmbed) {
+          throw new Error("Could not find prosemirrorEmbed variant");
+        }
+        // This rediculous hack is necessary to avoid having the image
+        // flash with a broken icon (in chrome, others?) for a second
+        // before it finally loads. The image is preloaded in a hidden
+        // position before being finally inserted into the prosemirror
+        // document.
+        return new Promise((resolve) => {
+          const img = document.createElement("img");
+          img.src = prosemirrorEmbed;
+          img.setAttribute(
+            "style",
+            "position: absolute; top: -10000px; left: -10000px;"
+          );
+          img.onload = () => {
+            resolve(prosemirrorEmbed);
+            document.body.removeChild(img);
+          };
+          document.body.append(img);
+        });
+      } else {
+        throw new Error("Could not get variants from upload response");
+      }
+    } catch (e) {
+      onError(e);
+      throw e;
     }
   };
   return {