Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs always prefixed by last word of extraction text #21

Open
midzdotdev opened this issue Sep 3, 2018 · 2 comments
Open

URLs always prefixed by last word of extraction text #21

midzdotdev opened this issue Sep 3, 2018 · 2 comments

Comments

@midzdotdev
Copy link

The algorithm used to extract the URL is really poor. All URLs contain the last word of tweet text at the start of the url. Twitter has published its own module which contains all of their code for extracting stuff from text, including URLs called twitter-text, it's on GitHub.

@sebinsua
Copy link
Owner

sebinsua commented Sep 3, 2018

Hello,

I'm happy to take a PR if you want to create one to use twitter-text.

There are quite a few issues with this package now. I have not been able to pay much attention to it, since I released it 2 years ago.

@midzdotdev
Copy link
Author

I really like this module, you've done some great work. Its likely that I'll actually fork it or create my own.

May I ask how you found the URLs that are used in this module? Such as https://twitter.com/i/profiles/show/${username}/timeline.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants