Clean up pre-loading of 'one' values in LSL compiler

Author: HaroldCindy

Compiler/include/Luau/LSLCompiler.h

@@ -17,9 +17,7 @@ struct LuauSymbolData {
     // Constants that need small indices (tracked during resource visitor pass)
     // Each import is stored as module,method pair (e.g., "bit32","bnot" or "lsl","cast")
     std::unordered_set<std::string> needed_import_strings; // Individual strings used in imports
-    bool needs_int_one = false;           // For integer ++/--
-    bool needs_float_one = false;         // For float ++/--
-    bool needs_vector_one = false;        // For vector ++/-- (unlikely but possible)
+    std::unordered_set<LSLType*> needed_one_types; // Types which we need the default `one` value for.
 };
 
 typedef std::unordered_map<LSLSymbol *, LuauSymbolData> LuauSymbolMap;

Compiler/src/LSLCompiler.cpp

@@ -113,13 +113,8 @@ bool LuauResourceVisitor::visit(LSLUnaryExpression *un_expr)
     if (op == OP_PRE_INCR || op == OP_POST_INCR || op == OP_PRE_DECR || op == OP_POST_DECR)
     {
         auto *lvalue = (LSLLValueExpression *)child_expr;
-        auto itype = lvalue->getIType();
-        if (itype == LST_INTEGER)
-            _mCurrentFunc->needs_int_one = true;
-        else if (itype == LST_FLOATINGPOINT)
-            _mCurrentFunc->needs_float_one = true;
-        else if (itype == LST_VECTOR)
-            _mCurrentFunc->needs_vector_one = true;
+        // We will need the type's `one` value as a low-indexed constant to do these ops
+        _mCurrentFunc->needed_one_types.insert(lvalue->getType());
     }
     else if (op == OP_BIT_NOT)
     {
@@ -495,14 +490,9 @@ void LuauVisitor::buildFunction(LSLASTNode *func_like)
 
     // Pre-allocate constants that need small indices (detected by LuauResourceVisitor)
     // Do this first to ensure they get low constant indices
-    if (sym_data.needs_int_one)
-        addConstantInteger(1, UINT8_MAX);
-    if (sym_data.needs_float_one)
-        addConstantFloat(1.0f, UINT8_MAX);
-    if (sym_data.needs_vector_one)
-    {
-        // Vector <1, 1, 1> for vector increment/decrement
-        addConstantUnder(TYPE(LST_VECTOR)->getOneValue(), UINT8_MAX);
+    for (auto one_type : sym_data.needed_one_types)
+    {
+        addConstantUnder(one_type->getOneValue(), UINT8_MAX);
     }
 
     // Pre-allocate import strings to ensure they're under index 1024