Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where multiple access points to a single source are used on an entity record, deduplicate the source table #760

Closed
tlongers opened this issue Jun 4, 2021 · 7 comments

Comments

@tlongers
Copy link
Member

tlongers commented Jun 4, 2021

At least for now (see discussion in #357) we are not going to show source data to the granuality of access points in the "sources" content area of persons and units records.

However, where a source is referenced more than once within a record, the source listing should be deduplicated to show it only once. I caught this issue here, where there are three rows for the same UN source:

image

@hancush
Copy link

hancush commented Jun 4, 2021

Great catch, @tlongers. I staged a patch for this on the org pages, e.g., https://back.securityforcemonitor.org/en/organization/view/fffa0ffc-e7e6-4d82-9173-d91df2edaf5d/#sources

Look ok to you? If so, I can replicate for the remaining entities on Monday!

@tlongers
Copy link
Member Author

tlongers commented Jun 9, 2021

That's a fix! Thanks.

I'm not sure if this should be addressed in a different PR but I noticed two other things about the sources table. I've reported in #763 and #764.

@hancush
Copy link

hancush commented Jun 10, 2021

Hey, hey, @tlongers – I've pushed a fix for this issue and #764 to the staging site. Would you mind checking out a few pages of each entity type to confirm everything looks above board? Will push to prod after your confirmation. Taking a look at #763 separately, now.

@tlongers
Copy link
Member Author

#764 looks great. I've responded on #763 - we'll address that problem in the next import round.

Strikes me we should also add some short descriptive text to the sources section:

"List of all sources used to evidence the data in this record. Click the "+" symbol next to every data point in the record to see the sources used for that data point."

@hancush
Copy link

hancush commented Jun 11, 2021

Help text deployed to staging. Look ok?

Screen Shot 2021-06-11 at 8 38 35 AM

@tlongers
Copy link
Member Author

Great; thanks.

@hancush
Copy link

hancush commented Jun 14, 2021

Deployed!

@hancush hancush closed this as completed Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants