-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aspect ratio of peer's video is wrong #32
Comments
Hello. I came across your post on reddit, and I'd like to contribute. I believe this issue can be a good stating point, right? |
yes!! thank you so much for reaching out brother!! |
@vitorsgoncalves the main issue is that the encoder's resolution is hardcoded, we do not even look at the aspect ratio that the device has: https://github.com/security-union/zoom-rs/blob/9a551e33412ab9169273dddbeecd9978a3713d20/yew-ui/src/components/host.rs#L425-L426 |
@vitorsgoncalves are you planning to take on this feature? |
Yes. I'm needing to learn a few things first, so I'm taking longer than expected.
|
I'm sorry, but I won't have much time to work on this from now on, and still didn't make much progress. I think it's better to let you assign someone else. |
Ok no worries, care to share what you tried? |
The aspect ratio is hardcoded.
Instead, the code should lazily adapt to the aspect ratio of the decoded images.
The text was updated successfully, but these errors were encountered: