test: check non-owner upgrading proxy

Author: mariocao

.solcover.js

@@ -3,6 +3,6 @@ module.exports = {
     grep: '[Gg]as.*[Aa]nalysis',
     invert: true,
   },
-  skipFiles: ['mocks/', 'interfaces/', 'libraries/SedaDataTypes.sol', 'test/'],
+  skipFiles: ['mocks/', 'interfaces/', 'libraries/', 'test/'],
   modifierWhitelist: ['initializer', 'onlyInitializing'],
 };

test/core/SedaCoreV1.proxy.test.ts

@@ -56,11 +56,20 @@ describe('Proxy: SedaCore', () => {
 
       // Upgrade to V2
       const proxyV2 = await upgrades.upgradeProxy(await proxy.getAddress(), CoreV2Factory);
-      await proxyV2.initialize();
+      await proxyV2.getFunction('initialize')();
 
       // Check new V2 functionality
       const version = await proxyV2.getVersion();
       expect(version).to.equal('2.0.0');
     });
+
+    it('prevents non-owner from upgrading the proxy', async () => {
+      const { core: proxy, CoreV2Factory } = await loadFixture(deployProxyFixture);
+      const [, nonOwner] = await ethers.getSigners();
+
+      await expect(
+        upgrades.upgradeProxy(await proxy.getAddress(), CoreV2Factory.connect(nonOwner)),
+      ).to.be.revertedWithCustomError(proxy, 'OwnableUnauthorizedAccount');
+    });
   });
 });

test/prover/Secp256k1ProverV1.proxy.test.ts

@@ -81,6 +81,14 @@ describe('Proxy: Secp256k1Prover', () => {
 
       await expect(proxyV2.initialize()).to.be.revertedWithCustomError(proxyV2, 'InvalidInitialization');
     });
+
+    it('prevents non-owner from upgrading the proxy', async () => {
+      const { proxy, ProverV2Factory, nonOwner } = await loadFixture(deployProxyFixture);
+
+      await expect(
+        upgrades.upgradeProxy(await proxy.getAddress(), ProverV2Factory.connect(nonOwner)),
+      ).to.be.revertedWithCustomError(proxy, 'OwnableUnauthorizedAccount');
+    });
   });
 
   describe('resettable variant', () => {