Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher icon color confusion #711

Open
t-m-w opened this issue Jul 31, 2024 · 5 comments
Open

Launcher icon color confusion #711

t-m-w opened this issue Jul 31, 2024 · 5 comments
Assignees
Labels

Comments

@t-m-w
Copy link
Collaborator

t-m-w commented Jul 31, 2024

The Seedvault launcher icon in the drawer (and likely home screen) responds inappropriately to Dark theme changes, sometimes remaining too light or too dark after theme changes - most noticeably, it may be quite bright in Dark mode. When this happens, you can sometimes see it shift instantly to a more/less appropriate color at the start of the launch/restore animation, and shift back at the end of the minimize animation.

Not all integrators add the Backup icon to the drawer, but CalyxOS does.

@t-m-w t-m-w added the bug label Jul 31, 2024
@theimpulson
Copy link
Collaborator

@t-m-w is this happening since M3 MR is merged or is it an old issue?

@t-m-w
Copy link
Collaborator Author

t-m-w commented Aug 15, 2024

@t-m-w is this happening since M3 MR is merged or is it an old issue?

It's still happening in the latest Seedvault code available as of today.

@t-m-w
Copy link
Collaborator Author

t-m-w commented Oct 17, 2024

Just wanted to note that this still occurs the same way, with all the latest Seedvault changes in the android15 branch.

@theimpulson
Copy link
Collaborator

theimpulson commented Oct 17, 2024

Just wanted to note that this still occurs the same way, with all the latest Seedvault changes in the android15 branch.

Could you please share steps to reproduce as I am unable to trigger the issue now on Android 15 build?

@t-m-w
Copy link
Collaborator Author

t-m-w commented Oct 17, 2024

Maybe this recording demonstrates it okay? I'm not sure how to describe how to reproduce this other than:

  1. Change the theme (dark theme on or off, or change the accent color)
  2. Drag the icon around

The dark theme color is also really bright for some reason.

screen-20241017-145813.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants