Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect usage of Tables.jl API #4

Closed
juliohm opened this issue Nov 2, 2021 · 2 comments
Closed

[BUG] Incorrect usage of Tables.jl API #4

juliohm opened this issue Nov 2, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@juliohm
Copy link
Collaborator

juliohm commented Nov 2, 2021

I always use TypedTables.jl in my test suite to make sure that my usage of Tables.jl is correct:

using TypedTables
using Plots, PairPlots

table = Table(a=rand(300), b=rand(300))

table |> corner

ERROR: BoundsError: attempt to access 300-element Table{NamedTuple{(:a, :b), Tuple{Float64, Float64}}, 1, NamedTuple{(:a, :b), Tuple{Vector{Float64}, Vector{Float64}}}} at index [2]

Could you please take a look at this error?

@sefffal
Copy link
Owner

sefffal commented Nov 2, 2021

Thanks for spotting this!
I will take a look.

@sefffal sefffal added the bug Something isn't working label Nov 2, 2021
@sefffal
Copy link
Owner

sefffal commented Nov 2, 2021

Okay, I fixed all the issues with TypedTables. This was a good exercise to make sure PairPlots isn't relying on anything besides the generic Tables.jl API.

However, I did have to work around a bug in TypedTables filed here: JuliaData/TypedTables.jl#86

The fix is pushed to master, and I will register a new patch release shortly.

@sefffal sefffal closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants