Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading major versions of dependencies should require a major version bump #20

Open
cmcewen opened this issue Jul 17, 2019 · 2 comments

Comments

@cmcewen
Copy link

cmcewen commented Jul 17, 2019

Ran into some issues with your Firebase version bump (running on a React Native app), which broke our build. I believe that if you update any dependency with a major version change, that should also require a major version change on your part

@kanclalg
Copy link

I also got some headache searching what broke our build today. I'm using nativescript and this update (analytics-android-integration-firebase v1.3.0) causes dependency conflicts with these nativescript plugins: nativescript-google-maps-sdk v2.7.0, nativescript-plugin-firebase v9.0.3.

I got few errors:

In project 'app' a resolved Google Play services library dependency depends on another at an exact version (e.g. "[18.0.
  0]", but isn't being resolved to that version. Behavior exhibited by the library will be unknown.
  
  Dependency failing: com.google.firebase:firebase-messaging:18.0.0 -> com.google.firebase:firebase-iid@[18.0.0], but fire
  base-iid version was 19.0.0.

and

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processDebugManifest'.
> Manifest merger failed : Attribute application@appComponentFactory value=(android.support.v4.app.CoreComponentFactory) from [com.android.support:support-compat:28.0.0] AndroidManifest.xml:22:18-91
        is also present at [androidx.core:core:1.0.0] AndroidManifest.xml:22:18-86 value=(androidx.core.app.CoreComponentFactory).
        Suggestion: add 'tools:replace="android:appComponentFactory"' to <application> element at AndroidManifest.xml:22:2-63:16 to override.

didn't do much digging, just downgraded the plugin to v1.2.0.
Anyway, I agree with @cmcewen that it should be major version release.

@sampsonjoliver
Copy link

Yep, I consume this plugin via the @segment/analytics-react-native-firebase plugin.

Unfortunately the @segment/analytics-react-native-firebase team don't reference any specific version of this Android plugin, and thus always acquire the latest regardless. This is blocking our application from building altogether for Android, with either a huge upgrade pathway to solve, or I'll just be removing the @segment/analytics-react-native-firebase integration until I can resolve this nightmare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants