Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Firebase client when Segment is reset #44

Open
stephen-mojo opened this issue Jun 30, 2022 · 0 comments
Open

Reset Firebase client when Segment is reset #44

stephen-mojo opened this issue Jun 30, 2022 · 0 comments

Comments

@stephen-mojo
Copy link

I was looking through the implementation of this integration and noticed that it does not override Integration.reset().

Would it make sense to reset the Firebase client in this method? I was thinking either by calling FirebaseAnalytics.resetAnalyticsData() or simply setting the user ID to null with FirebaseAnalytics.setUserId(null). This way, the user can be cleared when they log out by calling Segment's Analytics.with(context).reset()

@Override
public void reset() {
  super.reset();

  firebaseAnalytics.resetAnalyticsData();
  OR
  firebaseAnalytics.setUserId(null);

  logger.verbose("firebaseAnalytics.reset();");
}

See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant