Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geth upgrade test #2074

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

geth upgrade test #2074

wants to merge 1 commit into from

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Feb 14, 2025

Describe your changes and provide context

wip

Testing performed to validate your change

wip

@codchen codchen force-pushed the tony/integrate-geth-upgrade branch 2 times, most recently from 4c73b71 to 4c29f95 Compare February 17, 2025 04:16
return s.k.GetBalance(s.ctx, seiAddr)
res, overflow := uint256.FromBig(s.k.GetBalance(s.ctx, seiAddr))
if overflow {
panic("balance overflow")

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@codchen codchen force-pushed the tony/integrate-geth-upgrade branch from 4c29f95 to 9b4e161 Compare February 17, 2025 04:33
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 53.69458% with 94 lines in your changes missing coverage. Please review.

Project coverage is 61.25%. Comparing base (3a3af97) to head (b34986e).

Files with missing lines Patch % Lines
app/eth_replay.go 0.00% 19 Missing ⚠️
x/evm/keeper/keeper.go 6.66% 14 Missing ⚠️
x/evm/state/balance.go 58.62% 10 Missing and 2 partials ⚠️
x/evm/state/statedb.go 26.66% 11 Missing ⚠️
evmrpc/send.go 0.00% 9 Missing ⚠️
x/evm/keeper/genesis.go 0.00% 7 Missing ⚠️
evmrpc/simulate.go 72.22% 5 Missing ⚠️
x/evm/keeper/msg_server.go 78.94% 4 Missing ⚠️
x/evm/ante/fee.go 50.00% 2 Missing ⚠️
x/evm/module.go 0.00% 2 Missing ⚠️
... and 8 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
- Coverage   61.41%   61.25%   -0.16%     
==========================================
  Files         264      264              
  Lines       24647    24711      +64     
==========================================
+ Hits        15136    15137       +1     
- Misses       8383     8441      +58     
- Partials     1128     1133       +5     
Files with missing lines Coverage Δ
evmrpc/block.go 76.19% <100.00%> (+0.07%) ⬆️
evmrpc/state.go 52.50% <100.00%> (ø)
evmrpc/subscribe.go 66.16% <ø> (+0.65%) ⬆️
evmrpc/tracers.go 59.22% <100.00%> (ø)
evmrpc/txpool.go 73.80% <100.00%> (ø)
precompiles/common/precompiles.go 52.12% <100.00%> (+0.29%) ⬆️
x/evm/ante/basic.go 50.00% <100.00%> (ø)
x/evm/keeper/evm.go 69.07% <100.00%> (-0.41%) ⬇️
x/evm/keeper/pointer_upgrade.go 76.82% <100.00%> (+0.28%) ⬆️
x/evm/state/code.go 71.42% <100.00%> (+6.42%) ⬆️
... and 19 more

... and 1 file with indirect coverage changes

@codchen codchen force-pushed the tony/integrate-geth-upgrade branch 5 times, most recently from b9d3460 to e47a311 Compare February 18, 2025 08:38
@codchen codchen force-pushed the tony/integrate-geth-upgrade branch from e47a311 to b34986e Compare February 18, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant