Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RPC Response in CT CLI Query with Error #2078

Open
wants to merge 1 commit into
base: feature/ct_module
Choose a base branch
from
Open

Update RPC Response in CT CLI Query with Error #2078

wants to merge 1 commit into from

Conversation

mj850
Copy link
Contributor

@mj850 mj850 commented Feb 19, 2025

Describe your changes and provide context

We want to expose an Error field so that the Unmarshaled RPC Response can contain an error from the sei node.

  • Also: Do we need to change the RPC method from GET into POST?

Testing performed to validate your change

Unit tests

@mj850 mj850 changed the base branch from main to feature/ct_module February 19, 2025 16:12
@mj850 mj850 requested a review from dssei February 19, 2025 16:14
@mj850 mj850 closed this Feb 19, 2025
@mj850 mj850 reopened this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dssei dssei Awaiting requested review from dssei

Assignees
No one assigned
Labels
app-hash-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mj850