Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Issues #533

Open
TeoSaloufardos opened this issue Feb 16, 2025 · 4 comments · Fixed by #534
Open

Performance Issues #533

TeoSaloufardos opened this issue Feb 16, 2025 · 4 comments · Fixed by #534
Labels
bug performance Improve performance of an existing feature

Comments

@TeoSaloufardos
Copy link

Hi there,

I would like to inform you, that there is a performance issue with AdvancedPortals Plugin. Probably you can check this out using /spark profiler. The plugin consumes a lot amount of resources. Down bellow I have attached some screenshots in case of their are useful for you.

If you need the profiler file, please reach me out.

Thanks for your time, have a good one.

Image

Image

@sekwah41
Copy link
Owner

sekwah41 commented Feb 16, 2025

Ah so it is still around. Haven't had the time to look into this since the full recode so thanks for the metrics! I'll take a look and see. If I remember correctly there's two parts to this I planned. One is that paper at least has a few extras on top of spigot which can load the data significantly faster.

I'm currently trying to work on another feature first but will look at this next!

Just to check is this quite a noticeable spike or more a "hey can you improve this"? I'll be fixing it ether way but I'm typically on a solo local server so the stats will look different or harder to pick out for things like this.

@sekwah41 sekwah41 added bug performance Improve performance of an existing feature labels Feb 16, 2025
@sekwah41
Copy link
Owner

This one should be avoidable with a few basic checks to check if the trigger blocks are used for any portals or if the regions even contain a portal.

@sekwah41
Copy link
Owner

sekwah41 commented Mar 1, 2025

Didnt mean to close this. It was flagged as "fixed" in a pr that was merged

@sekwah41 sekwah41 reopened this Mar 1, 2025
@sekwah41
Copy link
Owner

sekwah41 commented Mar 1, 2025

Advanced-Portals-Spigot-2.3.3-chunk-load-optimisations-9f149830.jar.zip

Can you give that a try? See if this causes the same performance issues you outlined? If its all good ill merge it into the main branch :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug performance Improve performance of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants