Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol needs some tlc #19

Open
satra opened this issue Nov 22, 2024 · 5 comments
Open

protocol needs some tlc #19

satra opened this issue Nov 22, 2024 · 5 comments

Comments

@satra
Copy link
Contributor

satra commented Nov 22, 2024

this protocol has a bunch of things that don't seem correct.

  1. [validation issue] for a lot of items the name of the file and id dont match. seems like some autoconversion didn't understand reproschema
  2. for several items, the redcap2rs item seems fine, but was not used here (e.g. confounders)
  3. i added a brief readme, but currently the protocol isn't building because of validation issues.
@ibevers
Copy link
Collaborator

ibevers commented Nov 22, 2024

  1. The validation passes. I thought that should check file name and ID match. Is that not the case?

@ibevers
Copy link
Collaborator

ibevers commented Nov 22, 2024

  1. This seems non-critical. Do you agree?

@ibevers
Copy link
Collaborator

ibevers commented Nov 22, 2024

  1. The validation passes for me, but I'm using reprsochema==0.7.2. I see there is a newer one. I'll try that.

@ibevers
Copy link
Collaborator

ibevers commented Nov 22, 2024

@satra It passes the latest validation now

@satra
Copy link
Contributor Author

satra commented Nov 22, 2024

  1. This seems non-critical. Do you agree?

this makes us diverge between app updates and reproschema. while non-critical, quite inefficient, since we need to be in sync with the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants